[SMT][python] enable python bindings #8071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
force-pushed
the
users/makslevental/enable-smt-python-bindings
branch
from
a75d771 to
06a998e
Compare
|
Thanks! We test python bindings in |
|
@uenoku added a "smoke test" |
makslevental
force-pushed
the
users/makslevental/enable-smt-python-bindings
branch
from
0a8f5b3 to
20055ee
Compare
maerhart
approved these changes
Jan 13, 2025
include/circt-c/Dialect/SMT.h
Outdated
| @@ -0,0 +1,24 @@ | |||
| //===- SMT.h - C interface for the SMT dialect ----------------*- C -*-===// | |||
| @@ -0,0 +1,14 @@ | |||
| //===- SMTOps.td - Entry point for SMT bindings --------*- tablegen -*-===// | |||
|
|
||
| include "circt/Dialect/SMT/SMT.td" | ||
|
|
||
| #endif |
There was a problem hiding this comment.
Suggested change
| #endif | |
| #endif // BINDINGS_PYTHON_SMT_OPS |
lib/CAPI/Dialect/SMT.cpp
Outdated
| @@ -0,0 +1,14 @@ | |||
| //===- SMT.cpp - C interface for the SMT dialect ----------------------===// | |||
makslevental
deleted the
users/makslevental/enable-smt-python-bindings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the python bindings for the
smtdialect.I'm not sure what y'alls approach is to testing these bindings since PyCDE only tests the bindings it uses and I don't see any other python bindings tests around...