[CMake] enable install C API objects #8077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeurbach
approved these changes
Jan 13, 2025
makslevental
deleted the
users/makslevental/enable-capi-install-objects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to build CIRCT Python bindings downstream of CIRCT. For this to work you need to have the so-called "aggregate objects" installed.
add_circt_public_c_api_librarydoesDISABLE_INSTALLin order to preventadd_mlir_public_c_api_libraryfrom generating install targets that collide with those generated byadd_circt_library_installbut in doing so skips the install of the object fileobj.${name}. So we just put that back.EDIT: headers need to be installed too...