[CI/CD] Update upload-artifacts and download-artifcats. #8090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v3 of these actions is deprecated: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/. While GitHub has indicated this will stop working on January 30, we seem to have already hit a failure related to this: https://github.com/llvm/circt/actions/runs/12815228763/job/35733456176?pr=8089#step:1:25. This updates to use the v4 version of these actions where we were on v3, and in the Python wheel building specifically, it makes one small tweak following the migration guide: https://github.blog/news-insights/product-news/get-started-with-v4-of-github-actions-artifacts/#compatibility.
|
Manually kicked off the workflows that aren't tested in pre-merge. unifiedBuildTestAndInstall.yml: https://github.com/llvm/circt/actions/runs/12816324652 uploadWheels.yml (including push to PyPI): https://github.com/llvm/circt/actions/runs/12815570875 |
dtzSiFive
approved these changes
Jan 16, 2025
teqdruid
approved these changes
Jan 16, 2025
|
@teqdruid I took a look for anything using these actions, and ESI and PyCDE are already on v4. |
|
Excellent! Looks like I'm ahead of the curve. Thanks for checking. |
|
After a couple false start (pebkac), the Build, Test, and Install looks good.
|
|
Upload Wheels looks good too.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v3 of these actions is deprecated:
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/.
While GitHub has indicated this will stop working on January 30, we seem to have already hit a failure related to this: https://github.com/llvm/circt/actions/runs/12815228763/job/35733456176?pr=8089#step:1:25.
This updates to use the v4 version of these actions where we were on v3, and in the Python wheel building specifically, it makes one small tweak following the migration guide:
https://github.blog/news-insights/product-news/get-started-with-v4-of-github-actions-artifacts/#compatibility.