Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTG][Elaboration] Support fixed and virtual registers #8101

Merged
merged 1 commit into from
Jan 31, 2025
Merged

[RTG][Elaboration] Support fixed and virtual registers #8101

merged 1 commit into from
Jan 31, 2025

Conversation

maerhart
Copy link
Member

No description provided.

@maerhart maerhart added the RTG Involving the `rtg` dialect label Jan 21, 2025
@maerhart maerhart requested review from youngar and darthscsi January 21, 2025 15:13
youngar
youngar approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@youngar youngar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. An idea for the future: we could malloc the storage for VirtualRegister and use the address as the ID.

@maerhart maerhart mentioned this pull request Jan 31, 2025
Open
@maerhart maerhart force-pushed the maerhart-rtg-instructioninterface-improvement branch from 38d2c88 to 5ac5061 Compare January 31, 2025 17:04
Base automatically changed from maerhart-rtg-instructioninterface-improvement to main January 31, 2025 17:26
@maerhart maerhart force-pushed the maerhart-rtg-elaboration-registers branch from d67a85e to 3c6b6ab Compare January 31, 2025 17:30
@maerhart maerhart force-pushed the maerhart-rtg-elaboration-registers branch from 3c6b6ab to e1be502 Compare January 31, 2025 17:37
@maerhart maerhart merged commit 671dec5 into main Jan 31, 2025
5 checks passed
@maerhart maerhart deleted the maerhart-rtg-elaboration-registers branch January 31, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngar youngar youngar approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi

Assignees
No one assigned
Labels
RTG Involving the `rtg` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maerhart @youngar