Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove NFC button, scan the NFC if available right away #24

Closed
wants to merge 2 commits into from

Conversation

gorrdy
Copy link
Contributor

@gorrdy gorrdy commented Oct 9, 2023

When working with POS, people forgets to "tap" the NFC button when paying. It's better to try scanning the nfc right after the invoice is generated.

On desktop, where NFC is not by default it is not a problem, actually this is a better UX because it doesn't confuses the user with error "NFC not supported on this device".

On device with NFC it works automatically now.

@@ -372,7 +372,9 @@ <h5 class="q-mt-none">
if (typeof NDEFReader == 'undefined') {
throw {
toString: function () {
return 'NFC not supported on this device or browser.'
this.$q.notify({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this as workaround to not indicate anything if NFC is not supported. The goal is not to send any notification.

@gorrdy
Copy link
Contributor Author

gorrdy commented Oct 10, 2023

also added a (hopefully) fix. After payment the green checkmark was stuck on the screen. I put there a 5s interval until it disappears.

@talvasconcelos
Copy link
Collaborator

also added a (hopefully) fix. After payment the green checkmark was stuck on the screen. I put there a 5s interval until it disappears.

I think the intention is that it stays until clicked away, so merchant as a visual confirmation that payment was made! @arcbtc ?

@DoktorShift
Copy link

also added a (hopefully) fix. After payment the green checkmark was stuck on the screen. I put there a 5s interval until it disappears.

I think the intention is that it stays until clicked away, so merchant as a visual confirmation that payment was made! @arcbtc ?

This is good point. Out in the world the cashier sometimes are in talkes or get another order while one is paying. So green checkmark should stay until cashier clicked the tick away.

@talvasconcelos talvasconcelos mentioned this pull request Jan 18, 2024
@prusnak
Copy link
Collaborator

prusnak commented Jan 18, 2024

Superseded by #61

@prusnak prusnak closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants