Remove NFC button #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motorina0
reviewed
Jan 18, 2024
| ></lnbits-qrcode> | ||
| </q-responsive> | ||
| <a | ||
| :href="'lightning:' + invoiceDialog.data.payment_request.toUpperCase()" |
There was a problem hiding this comment.
nitpick: put this expression into a computed method (used in two places):
'lightning:' + invoiceDialog.data.payment_request.toUpperCase()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this PR, NFC button is removed. When payment is initiated, if available on the browser, the NFC will be readily available (or the browser will ask permission to turn it on). If not supported, it will show a small text with that information. Closes #24
The "Pay in wallet" button (introduced in #43) was also removed, it breaks the UI in small screens. Functionality is still available by clicking the QR code, as is standard behaviour.