Skip to content

Commit

Permalink
Allow flycheck process to exit gracefully
Browse files Browse the repository at this point in the history
Assuming it isn't cancelled. Closes rust-lang#17902.

The only place CommandHandle::join is used is when the flycheck command
finishes, so this commit changes the behavior of the method itself.
  • Loading branch information
tmandry committed Aug 15, 2024
1 parent a594a2d commit 23c8dcd
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ impl<T: ParseFromLine> CommandHandle<T> {
}

pub(crate) fn join(mut self) -> io::Result<()> {
let _ = self.child.0.kill();
let exit_status = self.child.0.wait()?;
let (read_at_least_one_message, error) = self.thread.join()?;
if read_at_least_one_message || exit_status.success() {
Expand Down

0 comments on commit 23c8dcd

Please sign in to comment.