Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: duplicated Sync in std::kinds #17902

Closed
nodakai opened this issue Oct 10, 2014 · 1 comment
Closed

rustdoc: duplicated Sync in std::kinds #17902

nodakai opened this issue Oct 10, 2014 · 1 comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@nodakai
Copy link
Contributor

nodakai commented Oct 10, 2014

Traits

                <tr>
                    <td>Send</td>
                    <td class='docblock short'><p>Types able to be transferred across task boundaries.</p>
                <tr>
                    <td>Sized</td>
                    <td class='docblock short'><p>Types with a constant size known at compile-time.</p>
                <tr>
                    <td>Sync</td>
                    <td class='docblock short'><p>Types that can be safely shared between tasks when aliased.</p>
                <tr>
                    <td>Sync</td>
                    <td class='docblock short'><p>Types that can be safely shared between tasks when aliased.</p>
Copy

Types that can be copied by simply copying bits (i.e. memcpy).

I suspect if the below line has anything to do with this issue:

pub use self::Sync as Share;

Cf. eg. std::ascii which re-exports self::AsciiExt.

@sfackler sfackler added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 10, 2014
@sfackler
Copy link
Member

Doesn't seem to be happening anymore.

lnicola pushed a commit to lnicola/rust that referenced this issue Aug 29, 2024
Assuming it isn't cancelled. Closes rust-lang#17902.

The only place CommandHandle::join is used is when the flycheck command
finishes, so this commit changes the behavior of the method itself.
lnicola pushed a commit to lnicola/rust that referenced this issue Aug 29, 2024
Allow flycheck process to exit gracefully

Assuming it isn't cancelled. Closes rust-lang#17902.

The only place CommandHandle::join() is used is when the flycheck command
finishes, so this commit changes the behavior of the method itself.

The only reason I can see for the existing behavior is if the command is somehow holding onto a build lock longer than it should, this would force it to be released. But it would be a pretty heavy-handed way to solve that issue. I'm not aware of this occurring in practice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants