-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds simple_media_bulk_upload #729
base: 3.x
Are you sure you want to change the base?
Conversation
"repositories": { | ||
"dropzone": { | ||
"type": "package", | ||
"package": { | ||
"name": "enyo/dropzone", | ||
"version": "6.0.0-beta.2", | ||
"type": "drupal-library", | ||
"dist": { | ||
"url": "https://github.com/dropzone/dropzone/releases/download/v6.0.0-beta.2/dist.zip", | ||
"type": "zip" | ||
} | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not so sure about this, is this fixing the version that will get installed? It means that it will need to be updated each time. Maybe we need to look at the composer merge plugin that some modules like webform or maybe use asset packagist instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fixing the version, yes, but there's hasn't been a new version in about 2 years so we probably won't be under too much pressure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Andy, any further thoughts on this, or are we okay to approve it?
Stimulating a wider discussion on how to manage libraries like this.
@andybroomfield thinks that most are moving to composer merge. |
@Adnan-cds mentioned :
|
@andybroomfield is up for taking this forward:
|
Drafting the composer merge plugin method here localgovdrupal/localgov_project#173 |
Closes #726
===
Thanks to Big Blue Door for sponsoring my time to work on this.