Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds simple_media_bulk_upload #729

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,40 @@
"type": "drupal-profile",
"license": "GPL-2.0-or-later",
"homepage": "https://github.com/localgovdrupal/localgov",
"repositories": [
{
"repositories": {
"dropzone": {
"type": "package",
"package": {
"name": "enyo/dropzone",
"version": "6.0.0-beta.2",
"type": "drupal-library",
"dist": {
"url": "https://github.com/dropzone/dropzone/releases/download/v6.0.0-beta.2/dist.zip",
"type": "zip"
}
}
},
Comment on lines +7 to +19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not so sure about this, is this fixing the version that will get installed? It means that it will need to be updated each time. Maybe we need to look at the composer merge plugin that some modules like webform or maybe use asset packagist instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fixing the version, yes, but there's hasn't been a new version in about 2 years so we probably won't be under too much pressure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Andy, any further thoughts on this, or are we okay to approve it?

"drupal": {
"type": "composer",
"url": "https://packages.drupal.org/8"
}
],
},
"require": {
"drupal/admin_toolbar": "^3.0",
"drupal/content_lock": "^2.4",
"drupal/core": "^10.0",
"drupal/dropzonejs": "^2.10",
"drupal/gin": "^3.0@alpha",
"drupal/gin_login": "^2.0.3",
"drupal/gin_toolbar": "^1.0@beta",
"drupal/entity_browser": "^2.9",
"drupal/preview_link": "^2.1@alpha",
"drupal/redirect": "^1.6",
"drupal/simple_media_bulk_upload": "^1.0",
"drupal/simple_sitemap": "^4.1",
"drupal/search_api": "^1.21",
"drush/drush": ">=10",
"enyo/dropzone": "^6.0.0-beta.2",
"localgovdrupal/localgov_alert_banner": "^1.2.0",
"localgovdrupal/localgov_base": "^1.3.1",
"localgovdrupal/localgov_core": "^2.12.0",
Expand Down
2 changes: 2 additions & 0 deletions localgov.info.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,13 @@ install:
- admin_toolbar:admin_toolbar
- admin_toolbar:admin_toolbar_tools
- entity_browser:entity_browser
- dropzonejs:dropzonejs
- gin_login:gin_login
- gin_toolbar:gin_toolbar
- preview_link:preview_link
- redirect:redirect
- redirect:redirect_404
- simple_media_bulk_upload:simple_media_bulk_upload
- simple_sitemap:simple_sitemap
# LocalGov Drupal
- localgov:localgov_login_redirect
Expand Down
Loading