Sets form to no-validate, so we can use Drupal validation instead

[markconroy]

Closes #503

What does this change?

HTML 5 validation is not very good. Drupal's form validation is much better.

This simply removes HTML 5 validation from forms - same approach as Disable HTML5 Validation module - so Drupal's form validation can take over instead.

Before:

After:

[andybroomfield]

Would we be able to put this behind a setting / config option? Be useful to introduce gradually to test.
Could be some issues if custom modules are dependant on html5 validation.

[andybroomfield]

Also I think this might be better in localgov_core?

[andybroomfield]

I tested and it works well, in that I get the Drupal validation errors and it makes a lot more sense. I'll need to check BHCC code to see if we are dependant on html5 validation anywhere.

[markconroy]

I wonder would it make sense as a theme setting? Or do we want it in a module to disable HTML5 validation everywhere?

[finnlewis]

I tested and it works well, in that I get the Drupal validation errors and it makes a lot more sense. I'll need to check BHCC code to see if we are dependant on html5 validation anywhere.

@andybroomfield [in the distant past, you commented](See: localgovdrupal/localgov_base#367 (comment)
) that:

Although this is focused on user login, and we should still fix the issue anyway for these cases, we should move away from using HTML5 validation if we want to match GDS guidelines.
see https://design-system.service.gov.uk/patterns/validation/

I see that the GDS guidelines specifically say "Turn off HTML5 validation."

So I agree with your previous comment and think we should merge this and roll out better validation by default.

What's the argument for making it optional?

If it really needs to be optional, we can use https://www.drupal.org/project/disable_html5_validation and install by default, allowing people to uninstall if desired.

[finnlewis]

I think we should go with this and happy to approve, but @andybroomfield I'd like you to be OK with this too.

[finnlewis]

Sorry, only just spotted the PHP static analysis failure, so just added a commit to address that.

[finnlewis]

All test pass now too :)

[finnlewis]

@millnut Quick question: are hooks (like this one) still OK in the .profile file or do we want to move them to a module?

[millnut]

I agree with @andybroomfield this should probably live in localgov_core so we don't have to move it at a later date with recipes.

[markconroy]

I have created the same PR in localgov_core now so we can merge that one instead if we are in agreement.

localgovdrupal/localgov_core#267

[finnlewis]

Thanks @markconroy

Closing this one in favour of localgovdrupal/localgov_core#267