Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML5 form validation #367

Closed
gavin-webstuff opened this issue Feb 8, 2023 · 3 comments
Closed

HTML5 form validation #367

gavin-webstuff opened this issue Feb 8, 2023 · 3 comments

Comments

@gavin-webstuff
Copy link
Contributor

HTML 5 validation tooltip is not displayed on forms on chrome

Steps to reproduce

  • any form seems to demonstrate the bug so long as the upon validation there is a need to scroll to element triggered

html5_no_validation_message
html5_validation_message
gavin-webstuff added a commit to gavin-webstuff/localgov_base that referenced this issue Feb 8, 2023
@gavin-webstuff
fix for HTML5 validation messages
4a242ed 
addresses an issue where HTML5 validation messages where not being displayed 

see issue localgovdrupal#367
@gavin-webstuff gavin-webstuff mentioned this issue Feb 8, 2023
Closed
@andybroomfield
Copy link
Contributor

Although this is focused on user login, and we should still fix the issue anyway for these cases, we should move away from using HTML5 validation if we want to match GDS guidelines.
see https://design-system.service.gov.uk/patterns/validation/

@markconroy markconroy mentioned this issue Feb 9, 2023
Open
@markconroy
Copy link
Member

I've created a follow up issue for disabling HTML5 validation: localgovdrupal/localgov#503

gavin-webstuff added a commit to gavin-webstuff/localgov_base that referenced this issue Feb 13, 2023
@gavin-webstuff
refactor scroll behaviour fixing issue localgovdrupal#367
6ab84d3
@markconroy
Copy link
Member

I'm going to close this issue since we have the related issue now in the localgovdrupal/localgov repo.

@finnlewis finnlewis mentioned this issue Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gavin-webstuff @andybroomfield @markconroy