Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need revisionOverview() in AlertBannerEntityController.php #323

Open
andybroomfield opened this issue May 6, 2024 · 1 comment
Open

Do we need revisionOverview() in AlertBannerEntityController.php #323

andybroomfield opened this issue May 6, 2024 · 1 comment
Milestone
v1.8

Comments

@andybroomfield
Copy link
Contributor

Theres a deprecation being flagged for renderPlain to renderInIsolation in Drupal 10.3.

We might be able to just remove it though, no other custom entity has this.
@andybroomfield
Copy link
Contributor Author

Add following to the entity and delete controller?

 *      "revision-delete" = \Drupal\Core\Entity\Form\RevisionDeleteForm::class,
 *       "revision-revert" = \Drupal\Core\Entity\Form\RevisionRevertForm::class,

andybroomfield added a commit that referenced this issue Jun 17, 2024
@andybroomfield
Initial refactor of revision provider and access
bab53b1 
Fix #323

Refactor the alert banner entitiy to use a more standard approach to revisions,
using \Drupal\Core\Entity\Routing\RevisionHtmlRouteProvider
instead of custom routes, and using standard revsion routes instead of custom
versions in routing.yml.

This also groups all the none view crud permissions into the manage alert
banner permission in alertBannerEntityAccessControlHandler.
@andybroomfield andybroomfield mentioned this issue Jun 17, 2024
Merged
@andybroomfield andybroomfield added this to the v1.8 milestone Jun 17, 2024
andybroomfield added a commit that referenced this issue Jun 18, 2024
@andybroomfield
Initial refactor of revision provider and access
4b201ad 
Fix #323

Refactor the alert banner entitiy to use a more standard approach to revisions,
using \Drupal\Core\Entity\Routing\RevisionHtmlRouteProvider
instead of custom routes, and using standard revsion routes instead of custom
versions in routing.yml.

This also groups all the none view crud permissions into the manage alert
banner permission in alertBannerEntityAccessControlHandler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8
Development

No branches or pull requests
1 participant
@andybroomfield