Initial refactor of revision provider and access #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #323 Refactor the alert banner entitiy to use a more standard approach to revisions, using \Drupal\Core\Entity\Routing\RevisionHtmlRouteProvider instead of custom routes, and using standard revsion routes instead of custom versions in routing.yml. This also groups all the none view crud permissions into the manage alert banner permission in alertBannerEntityAccessControlHandler.
andybroomfield
force-pushed
the
fix/1.x-323-revision-refactor
branch
from
bab53b1
to
4b201ad
Compare
Normally not required as the view is in place, but sometimes needed if the view is disabled.
andybroomfield
force-pushed
the
fix/1.x-323-revision-refactor
branch
from
e95be00
to
19bbddc
Compare
|
Taking this out of draft. focusing this PR on just removing the history routes and using the standard Drupal provided ones. |
Note: this may still get removed later in the refactor, but for now restore route admin/structure/alert-banner-types
andybroomfield
force-pushed
the
fix/1.x-323-revision-refactor
branch
from
c754953
to
dca5050
Compare
|
I will leave it to you Andy :) |
|
Very happy to get the 1.8.x branch into a ready state for review. If we can get the tests running on merges INTO 1.8.x - that should help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #323
Refactor the alert banner entitiy to use a more standard approach to revisions, using
\Drupal\Core\Entity\Routing\RevisionHtmlRouteProviderinstead of custom routes, and using standard revsion routes instead of custom versions in routing.yml.This also groups all the non view crud permissions into the manage alert banner permission in alertBannerEntityAccessControlHandler.
This is the first part of a refactor for version 1.8.