Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format templates to follow Drupal practices #123

Merged
merged 4 commits into from
Apr 29, 2021

Conversation

markconroy
Copy link
Member

Closes #122

@andybroomfield
Copy link
Contributor

This is really good, thanks @markconroy.
If we can get the tests passing again, I think it is just changing the class of several elements it looks for when checking if the banner is present and the hide button, then this should be good to merge.

@markconroy
Copy link
Member Author

@andybroomfield I've changed one test where I could see the class needed to change, but tests seem to be still breaking. Could you fix that by any chance?

@andybroomfield
Copy link
Contributor

Sometimes we have to re-run the tests if the tests have been changed, maybe something to do with paratest? @stephen-cox

@markconroy
Copy link
Member Author

Looks like it passed.

@andybroomfield if you're okay with this now can I leave it to you to merge this for the release?

If anyone is using localgov_theme, they will need to update their CSS classes - I think the only one might be changing localgov_alert_banner to localgov-alert-banner.

Thanks a lot. I'm really happy with how this module has turned out. Great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Frontend to follow Drupal practices
2 participants