Amend alert banner styles for new markup #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to account for the changes in the 1.0.0 release of localgov_alert_banner
Add annoucement colour (vividian) as variable and into sass Seperate localgov-alert-banner modifers from general alert-bar class Fix the dismiss class to new class localgov-aler-banner__close
cjstevens78
approved these changes
May 5, 2021
|
@stephen-cox Why do the tests run |
Copy and paste error 🙄 Will fix |
|
OK, I'm going to merge this one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #181
Required for alert banner 1.0.0 release following localgovdrupal/localgov_alert_banner#123
Not sure if this is actully used, however the sass looked like the old style
alerts, so I've tried to preserve that and add the new classes to alert banner
can be customised from the theme.