Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.1 release for Drupal 9 support #139

Merged
merged 9 commits into from
May 18, 2021
Merged

1.0.1 release for Drupal 9 support #139

merged 9 commits into from
May 18, 2021

Conversation

stephen-cox
Copy link
Member

@stephen-cox stephen-cox commented May 14, 2021

This is needed for Drupal 9 tests to start passing

Changelog:

#132 @stephen-cox Code Fixes for Drupal 9 support
#135 @andybroomfield Delete AlertBannerRouteSubscriber.php
#140 @stephen-cox Updated Github CI to run 1.x branch against Drupal 8 and 9

andybroomfield and others added 4 commits May 11, 2021 00:46
As the route subscriber was the only service, there is nothing in this file now.
…esubscriber

Delete AlertBannerRouteSubscriber.php
@andybroomfield
Copy link
Contributor

@stephen-cox Are the tests fail a known issue and this will need merging to pass, or is this still under investigation?

@stephen-cox
Copy link
Member Author

This needs to be merged for other tests to pass, but the failure here is not expected; the install should complete, the other tests should fail on specific modules. I'll need to investigate

@finnlewis finnlewis self-requested a review May 18, 2021 15:35
Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just the alert_banner CS checks as expected.

@stephen-cox stephen-cox merged commit e1cea4f into release-1.x May 18, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants