-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0.1 release for Drupal 9 support #139
Conversation
As the route subscriber was the only service, there is nothing in this file now.
…esubscriber Delete AlertBannerRouteSubscriber.php
@stephen-cox Are the tests fail a known issue and this will need merging to pass, or is this still under investigation? |
This needs to be merged for other tests to pass, but the failure here is not expected; the install should complete, the other tests should fail on specific modules. I'll need to investigate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Just the alert_banner CS checks as expected.
This is needed for Drupal 9 tests to start passing
Changelog:
#132 @stephen-cox Code Fixes for Drupal 9 support
#135 @andybroomfield Delete AlertBannerRouteSubscriber.php
#140 @stephen-cox Updated Github CI to run 1.x branch against Drupal 8 and 9