Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Github CI to run 1.x branch against Drupal 8 and 9 #140

Merged
merged 2 commits into from
May 18, 2021

Conversation

stephen-cox
Copy link
Member

@stephen-cox
Copy link
Member Author

@andybroomfield The test failure here are expected as they refer to deprecated code in core. Otherwise everything is now passing.

If you're happy for this to be merged, we can then rerun the tests for the 1.0.1 PR and the tests should pass expect for then same deprecated code issues with localgov_core.

@stephen-cox stephen-cox changed the title Updated Github CI to run 1.x branch against Drupal 8 Updated Github CI to run 1.x branch against Drupal 8 and 9 May 18, 2021
Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (and we agreed that we could review internally for this round of pull requests)

@stephen-cox stephen-cox merged commit a2664b5 into 1.x May 18, 2021
@stephen-cox stephen-cox deleted the feature/225-rename-master-to-1.x branch May 18, 2021 13:49
stephen-cox added a commit that referenced this pull request May 18, 2021
#132 @stephen-cox Code Fixes for Drupal 9 support
#135 @andybroomfield Delete AlertBannerRouteSubscriber.php
#140 @stephen-cox Updated Github CI to run 1.x branch against Drupal 8 and 9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants