Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for 1.6.4 #286

Merged
merged 4 commits into from
Sep 8, 2023
Merged

PR for 1.6.4 #286

merged 4 commits into from
Sep 8, 2023

Commits on Sep 6, 2023

  1. Fix failing Hide alert banner test

    Remove testing in default localgov profile
    This is beause the profile is testing the home page, which with the profile
    is now the user login page now that
    localgovdrupal/localgov#613
    is merged means that is the user login page.
    andybroomfield committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    a5e5358 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ea60b9 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Remove Drupal and drupalSettings from alert banner js

    Fix #284 
    
    In Drupal 10 it was discovered that the core/drupal and drupalSettings arn't sent by default. They should be explicitlly declared as dependencies, however we don't actully use these so we can saftley remove them for now.
    andybroomfield committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    985612e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #285 from localgovdrupal/fix/1.x-284-js-test-fail

    Remove Drupal and drupalSettings from alert banner js
    andybroomfield committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    e2dc513 View commit details
    Browse the repository at this point in the history