1.7.0 #622
1.7.0 #622
Conversation
…lows Use shared GitHub workflows to run tests
Merge back to fix branch.
Fix/580/alert banner dialog
…b-token Adds a variable to let us print a token for replacement in the breadcrumb trail.
This has several side-effects, all of them small: - the aria-label attribute is lost - prev/next links now wrapped in div.lgd-prev_next__label - labels now say "Previous" and "Next" instead of "Previous Step" and "Next Step" - labels are now bold - distance between links and footer now *more* consistent with other CTs Closes #565
Add tabindex -1 to skip link target
Prior to this change, screen readers read "Next colon link". After, they no longer pronounce "colon". When title is set, the colon is included an spoken.
…utton-focus adds better focus orders for services button/menu
…r_step_by_step_and_publications_prev_next feat: replaces standalone prev-next code with included version
Note: this doesn't re-hide the link in circumstances where the viewport size and size of content before #main-content mean the link is always visible when #main-content scrolls into view.
Template now uses localgov_base _components/prev_next.twig.
…r-publications-prev-next 564 use prev next twig for publications prev next
ensures quick fact content is inside a <p> tag
adds CSS for blockquotes created via WYSIWYG
…teps-nav hides guides/steps navigation in print mode
…llapse-to-accordion feat: add expand/collapse icon to accordion
adds more space for clickable area for pager items
…ice-status-heading fix: set color on service status heading
* initial commmit of sticky header settings for localgov_base * moves class addition to preprocess_html * sets default value * check for setting before setting it * renames support module to helper * adds CSS + JS for sticky header * rewrite to only use sticky header for logged out users * update description for form item * coding standards fixes * removes duplicate code * only apply the scroll check if the header type is set to scroll * Add scroll-padding-top to the html and body when we have a sticky header * coding standards fixes --------- Co-authored-by: Maria Young <maria@agile.coop>
|
Is there a dependency on |
…map-field Add alt text to announce map link opens in a new tab
|
= Blocker breaker To release this these MRs should be merged at the same time: For LocalGov: For LocalGov Microsites:
With these three #624 is resolved. I have an open question if the tests will still pass, but that might just be my local #623 |
|
My notes about how to manually test (from Slack) To review it all you'd have to: |
|
@ekes One thing I spotted on the "front end" is that #603 adds icons as expected, however this adds them to all sites even if they have overwritten the Twig template to introduce their own icons: |
|
@ekes Applying patches for drupal/preview_link and Looks like there are re-rolled patches available |
* Revert "adds checkmark icon" This reverts commit e5ef66b. * adds checkbox icon * Add word-wrap to prevent overflow on .lgd-guide-nav__list --------- Co-authored-by: Mark Conroy <mark@mark.ie> Co-authored-by: Finn Lewis <finn@opencode.uk> Co-authored-by: Stephen Cox <stephen-cox@users.noreply.github.com> Co-authored-by: Andy Broomfield <andybroomfield@gmail.com>
|
The test failures I'm getting with this are: |
Release Notes
We have a number of new features in this release:
Sticky headers
If you want your site to have a sticky header when someone scrolls, you can check a checkbox now on the theme settings page. It has 3 options - not sticky, sticky, only sticky when scrolling.
Better focus order for header
When tabbing through the header, the focus order is not more suited for screenreader users. Especially when you tab into and then out of the services menu.
iOS Skip to Content link
We had a nasty issue which was very hard to replicate where keyboard users on iOS (iPhone, iPad) couldn't use the 'Skip to Content' link. Now they can.
Back to top
We have a checkbox now to switch on/off a "Back to top" button which will appear after you scroll more than the height of your screen
Accordion icons
Accordions now have a
+icon when they are collapsed and a-icon when they are expandedPrint mode
When printing a step-by-step or guide page now the navigation will not be printed.