Ignore patch from services module while Drupal 10.2 is still supported #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-cox
changed the title
stephen-cox
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
I think this is good and should be merged and released ASAP to fix the GitHub test runs (or at least fix the install to allow the tests to run).
As we're requiring 10.3 for new installs I suggest a minor release bump (to 3.1.0)
@finnlewis @ekes @andybroomfield @Adnan-cds @millnut Any thoughts / concerns on this?
|
Looks good to me, I'll create a new ticket in services to remove the patch completely when Drupal 10.2 is EoL in Dec 2024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.