Fix ui shows wrong number of requests

locustio · Nov 29, 2024 · 665101e · 665101e
1 parent de9af6a
commit 665101e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 18 deletions.
diff --git a/locust/webui/eslint.config.mjs b/locust/webui/eslint.config.mjs
@@ -1,15 +1,16 @@
-import react from 'eslint-plugin-react';
-import reactHooks from 'eslint-plugin-react-hooks';
+import { fixupPluginRules } from '@eslint/compat';
+import { FlatCompat } from '@eslint/eslintrc';
+import js from '@eslint/js';
 import typescriptEslint from '@typescript-eslint/eslint-plugin';
+import tsParser from '@typescript-eslint/parser';
+import _import from 'eslint-plugin-import';
 import prettier from 'eslint-plugin-prettier';
+import react from 'eslint-plugin-react';
+import reactHooks from 'eslint-plugin-react-hooks';
 import unusedImports from 'eslint-plugin-unused-imports';
-import _import from 'eslint-plugin-import';
-import { fixupPluginRules } from '@eslint/compat';
-import tsParser from '@typescript-eslint/parser';
+
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
-import js from '@eslint/js';
-import { FlatCompat } from '@eslint/eslintrc';
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);

diff --git a/locust/webui/src/hooks/useFetchStats.ts b/locust/webui/src/hooks/useFetchStats.ts
@@ -24,12 +24,13 @@ export default function useFetchStats() {
   const shouldRunRefetchInterval =
     swarm.state === SWARM_STATE.SPAWNING || swarm.state == SWARM_STATE.RUNNING;
 
-  const updateStats = () => {
+  useEffect(() => {
     if (!statsData) {
       return;
     }
 
     const {
+      state,
       currentResponseTimePercentiles,
       extendedStats,
       stats,
@@ -80,17 +81,9 @@ export default function useFetchStats() {
       userCount,
     });
     updateCharts(newChartEntry);
-  };
 
-  useEffect(() => {
-    if (statsData) {
-      setSwarm({ state: statsData.state });
-    }
-  }, [statsData && statsData.state]);
-
-  useInterval(updateStats, STATS_REFETCH_INTERVAL, {
-    shouldRunInterval: !!statsData && shouldRunRefetchInterval,
-  });
+    setSwarm({ state });
+  }, [statsData]);
 
   useInterval(refetchStats, STATS_REFETCH_INTERVAL, {
     shouldRunInterval: shouldRunRefetchInterval,