Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nanoseconds in string to date time conversions #270

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Use nanoseconds in string to date time conversions #270

merged 3 commits into from
Dec 27, 2023

Conversation

joachimmetz
Copy link
Member

No description provided.

@joachimmetz joachimmetz self-assigned this Dec 10, 2023
@joachimmetz joachimmetz mentioned this pull request Dec 10, 2023
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f774504) 96.15% compared to head (191a0b7) 96.18%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   96.15%   96.18%   +0.03%     
==========================================
  Files          24       24              
  Lines        2316     2335      +19     
==========================================
+ Hits         2227     2246      +19     
  Misses         89       89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sydp
sydp requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@sydp sydp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some thoughts for your consideration.

Thanks for adding this, it should help address my other issue on plaso.

tests/precisions.py Outdated Show resolved Hide resolved
dfdatetime/cocoa_time.py Show resolved Hide resolved
dfdatetime/dotnet_datetime.py Show resolved Hide resolved
dfdatetime/fat_date_time.py Show resolved Hide resolved
dfdatetime/ole_automation_date.py Outdated Show resolved Hide resolved
dfdatetime/filetime.py Show resolved Hide resolved
sydp
sydp approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@sydp sydp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joachimmetz joachimmetz added the to merge Issue has been reviewed and can be merged when checks are complete label Dec 14, 2023
@joachimmetz
Copy link
Member Author

I'll merge the changes after the next Plaso release

@sydp sydp mentioned this pull request Dec 20, 2023
Merged
3 tasks
@joachimmetz joachimmetz removed the to merge Issue has been reviewed and can be merged when checks are complete label Dec 27, 2023
@joachimmetz joachimmetz merged commit eae9726 into log2timeline:main Dec 27, 2023
11 checks passed
@joachimmetz joachimmetz deleted the nanosecs branch December 27, 2023 06:10
@joachimmetz joachimmetz linked an issue Dec 27, 2023 that may be closed by this pull request
Add support to parse nanoesecond timestamp formats to GolangTime #263
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydp sydp sydp approved these changes

Assignees

@joachimmetz joachimmetz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to parse nanoesecond timestamp formats to GolangTime
2 participants
@joachimmetz @sydp