-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Container Runtime Interface log parser #4742
Conversation
This is dependent on |
Thanks for the PR, I'll take a look as time permits. |
CI tests are failing with
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4742 +/- ##
==========================================
- Coverage 85.21% 85.13% -0.08%
==========================================
Files 428 430 +2
Lines 38826 38908 +82
==========================================
+ Hits 33084 33123 +39
- Misses 5742 5785 +43 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One line description of pull request
Adds support for the CRI text log format seen in GKE.
Description:
Related issue (if applicable): fixes #4616
Notes:
All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.
One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.
Checklist: