Develop #10
Merged
Develop #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woz5999
reviewed
May 6, 2019
| // Whether to create a collector device when instance collector | ||
| NeedAutoCreateCollectorDevice bool `json:"needAutoCreateCollectorDevice,omitempty"` | ||
| // Whether to create a collector device when instance collector, the default value is true | ||
| NeedAutoCreateCollectorDevice interface{} `json:"needAutoCreateCollectorDevice,omitempty"` |
There was a problem hiding this comment.
@JeremyTangCD Why are these properties interfaces now instead of bool?
There was a problem hiding this comment.
@woz5999
You can get the details in DEV-43101.
Same reason as #6, the default value in santaba is true, if we set the value as false, go sdk will treat this value as the default value and does not send it to santaba, then we get in santaba will be true
In #6, we just delete the "omitempty" tag from the sdk manually.
But since the sdk should only be auto-generated, we need to improve this case by improve the annotation in santaba. We could not change this field to be required, so we only have to change the type of this value and add some description for it.
woz5999
pushed a commit
that referenced
this pull request
May 8, 2019
* Automated release commit release-7 * Build from latest swagger revision (#3) * Fix AddCollector by using pointers * don't omit empty for failback (#2) * rebuild from upstream swagger updates * update docs * rebuild from auth updates * simplify request signing * Automated release commit release-11 * Automated release commit release-11 * Automated release commit release-11 * Automated release commit release-11 * Automated release commit release-11 * boilerplate * Develop (#9) * Create main.go * Update main.go * Develop (#10) * Create main.go * Update main.go * add sub groups field for device group * improve the NeedAutoCreateCollectorDevice field * disable the html escape during json encode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve the go sdk for argus project