Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't omit empty for failback #2

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

woz5999
Copy link
Contributor

@woz5999 woz5999 commented Mar 15, 2018

the API default is "true" so by omitting empty, you can't specify a false value for this

@andrewrynhard
Copy link
Contributor

LGTM

@andrewrynhard andrewrynhard self-assigned this Mar 15, 2018
@woz5999 woz5999 merged commit cc3e89a into master Mar 15, 2018
@andrewrynhard andrewrynhard deleted the collector-failback-shouldn't-omit-empty branch March 15, 2018 21:00
woz5999 added a commit that referenced this pull request May 21, 2018
* Fix AddCollector by using pointers

* don't omit empty for failback (#2)

* rebuild from upstream swagger updates

* update docs

* rebuild from auth updates

* simplify request signing
woz5999 pushed a commit that referenced this pull request Apr 25, 2019
* Automated release commit release-7

* Build from latest swagger revision (#3)

* Fix AddCollector by using pointers

* don't omit empty for failback (#2)

* rebuild from upstream swagger updates

* update docs

* rebuild from auth updates

* simplify request signing

* Automated release commit release-11

* Automated release commit release-11

* Automated release commit release-11

* Automated release commit release-11

* Automated release commit release-11

* boilerplate

* Develop (#9)

* Create main.go

* Update main.go
woz5999 pushed a commit that referenced this pull request May 8, 2019
* Automated release commit release-7

* Build from latest swagger revision (#3)

* Fix AddCollector by using pointers

* don't omit empty for failback (#2)

* rebuild from upstream swagger updates

* update docs

* rebuild from auth updates

* simplify request signing

* Automated release commit release-11

* Automated release commit release-11

* Automated release commit release-11

* Automated release commit release-11

* Automated release commit release-11

* boilerplate

* Develop (#9)

* Create main.go

* Update main.go

* Develop (#10)

* Create main.go

* Update main.go

* add sub groups field for device group

* improve the NeedAutoCreateCollectorDevice field

* disable the html escape during json encode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants