Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add v8 to ecs_compatibility options #1059

Merged
merged 3 commits into from
Feb 15, 2022

Conversation

karenzone
Copy link
Contributor

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

@karenzone karenzone added the docs label Dec 21, 2021
@karenzone
Copy link
Contributor Author

@kares or @yaauie: Is this a change that we need to make? Thanks for looking.

Copy link
Contributor

@kares kares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 we do want this to be documented.

the template itself will be v1 even for v8 up till 8.0 is actually released (ECS release 8.0), unsure here whether that is worth mentioning - in my opinion it's transient and not necessary.

@kares
Copy link
Contributor

kares commented Jan 24, 2022

the template itself will be v1 even for v8 up till 8.0 is actually released (ECS release 8.0), unsure here whether that is worth mentioning - in my opinion it's transient and not necessary.

actually, since #1062 there's not a BEAT v8 template being shipped.
v1 template also got an update but this isn't mentioned (whether it's worth specifying might be up for discussion)

@karenzone
Copy link
Contributor Author

@kares

the template itself will be v1 even for v8 up till 8.0 is actually released (ECS release 8.0)

Is this accurate now that 8.0 has shipped?

@kares
Copy link
Contributor

kares commented Feb 15, 2022

Is this accurate now that 8.0 has shipped?

That has changed recently with #1062 ... seems like we generated the v8 from the upstream (unreleased at that time) ECS v8 files.

@karenzone karenzone merged commit fe0a241 into logstash-plugins:main Feb 15, 2022
@karenzone karenzone deleted the ecs-v8 branch February 15, 2022 16:20
@karenzone
Copy link
Contributor Author

PENDING PUBLISHING: CI not green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants