ECS Templates: stack alignment #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaauie
commented
Dec 22, 2021
yaauie
force-pushed
the
ecs-stack-alignment
branch
from
7584cc3
to
50211e4
Compare
yaauie
force-pushed
the
ecs-stack-alignment
branch
from
50211e4
to
315c0d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolution of #1060.
With ECS 8.0, ECS is becoming Stack-aligned, and no longer generates template artifacts for other Elasticsearch majors. This is causing some paths to change in the upstream project from which we vendor our templates.
They continue to generate a monolith "legacy" template, for use with the Elasticsearch "legacy" template API (a.k.a., v1), but this plugin automatically uses the v2 template endpoint when persisting templates to Elasticsearch 8.
Historically, this plugin has provided ECS v1 templates for (unreleased) Elasticsearch 8 by transforming them into the v2 format prior to vendoring. This changeset builds upon that work, renaming the relevant methods to be more descriptive and separating the concerns of transforming the template from those of defining which versions top vendor.
It also includes a number of build fixes.