feat: Fix build and add custom get scope range function #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aranard
changed the title
|
@aranard My apologies for the long delay in reviewing this PR. Could you please separate it into two PRs, one fixing the build, and one adding the new functionality? Please include tests and documentation for the new feature as well. |
|
@aranard Can you reduce this PR to the new functionality, please? The build and tests in CI are fixed now, so the turnaround time would be much smaller. |
|
@terales yes will do! Thanks for the update. I should be able to do this sometime next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the build break caused by #735
Also addresses this feature request: #813