-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix react-i18next(and next-i18next) framework integration #735
Conversation
Hello @SimeonC |
I'm unfortunately powerless to merge this. As far as I'm aware it's all correct and ready to merge. |
Oh alright, I thought it was to you to merge this. Sorry for the noise… |
+1 for merge Is project dead? |
Has this change been released? I am a bit confused, as for me v4-style plurals don't seem to work and #688 is still open. |
Is this project still being actively maintained? I'd like to contribute a feature that will help my team, and I'm running into issues getting the extension to build. This seems to be in part because of this change being merged. The splitting of Is this something anyone is actively aware of or looking into? Thanks. |
import { I18nextFramework } from './i18next' | ||
import { LanguageId } from '~/utils' | ||
|
||
class ReactI18nextFramework extends Framework { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does not seem to have been checked at all. Surely ReactI18nextFramework
should be extending I18nextFramework
and not Framework
. I18nextFramework
is also a default export and not a named one...
This whole PR is broken and adds nothing to the extension except for supporting pluralization. It breaks imports, has the wrong usage patterns, and doesn't even add itself to the frameworks list. Please revert this PR and add the pluralization to the i18next framework instead.
|
I've found maintainers only reply here if you send them a request through Lokalise customer support. |
Fixing the react-i18next framework to extend the base i18next framework as there shouldn't be many differences between them.
Also added in the v4 plurals fixing #677 and #688
In the image below, i18n-a11y is detecting the file if I use a

.
but not if I use a:
(the:
here is correct as it's a namespaced file)