i_sender ownership fix (VowpalWabbit#33)

* i_sender ownership fix * unit test fix Looks good. Thanks.
lokitoth · Jan 16, 2019 · 6245ffc · 6245ffc
1 parent 4299daf
commit 6245ffc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/rlclientlib/logger/preamble_sender.h b/rlclientlib/logger/preamble_sender.h
@@ -9,6 +9,6 @@ namespace reinforcement_learning { namespace logger {
       int send(const uint16_t msg_type, const buffer& db, api_status* status) override;
       int init(api_status* status) override;
     private:
-      i_sender* _sender;
+      std::unique_ptr<i_sender> _sender;
     };
 }}
diff --git a/unit_test/preamble_test.cc b/unit_test/preamble_test.cc
@@ -29,16 +29,16 @@ struct dummy_sender : i_sender {
 
 BOOST_AUTO_TEST_CASE(simple_preamble_usage) {
   std::shared_ptr<data_buffer> db(new data_buffer());
-  dummy_sender raw_data;
-  preamble_message_sender f_sender(&raw_data);
+  dummy_sender* raw_data = new dummy_sender();
+  preamble_message_sender f_sender(raw_data);
   i_message_sender& sender = f_sender;
   db->set_body_endoffset(db->preamble_size()+db->body_capacity());
   const auto send_msg_sz = db->body_filled_size();
   const auto send_msg_type = message_type::fb_ranking_event_collection;
 
   sender.send(send_msg_type, db);
   preamble pre;
-  pre.read_from_bytes(raw_data.v_data->preamble_begin(), raw_data.v_data->preamble_size());
+  pre.read_from_bytes(raw_data->v_data->preamble_begin(), raw_data->v_data->preamble_size());
 
   BOOST_CHECK_EQUAL(pre.msg_size, send_msg_sz);
   BOOST_CHECK_EQUAL(pre.msg_type, send_msg_type);