Skip to content

Commit

Permalink
fix: remove python setup.py author_email (#787)
Browse files Browse the repository at this point in the history
we no longer have support@looker.com and this field only accepts
a valid email address. sadly twine check does not catch this error
yet, hopefully it will some day.

Factored the twine check out of the unit matrix: it only needs to run once
  • Loading branch information
joeldodge79 authored Aug 9, 2021
1 parent 151cd12 commit 7939a73
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 9 deletions.
21 changes: 15 additions & 6 deletions .github/workflows/python-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,6 @@ jobs:
pip install tox
- name: Run Unit Tests
run: tox -e unit
- name: Twine upload check
run: |
pip install wheel twine
python setup.py sdist bdist_wheel
twine check dist/*
- name: Upload pytest test results
if: ${{ always() }}
uses: actions/upload-artifact@v2
Expand Down Expand Up @@ -187,8 +182,22 @@ jobs:
name: python-test-results
path: python/results/

twine:
needs: integration
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
with:
python-version: 3.x
- name: Twine upload check
run: |
pip install wheel twine
python setup.py sdist bdist_wheel
twine check dist/*
publish-test-results:
needs: [unit, integration]
needs: [unit, integration, twine]
if: success() || failure()
runs-on: ubuntu-latest

Expand Down
5 changes: 2 additions & 3 deletions python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,12 @@

setup(
author="Looker Data Sciences, Inc.",
author_email="Looker Team <https://help.looker.com>",
description="Looker API 3.1",
description="Looker REST API",
install_requires=REQUIRES,
license="MIT",
long_description=open("README.rst").read(),
long_description_content_type="text/x-rst",
keywords=["Looker", "Looker API", "looker_sdk", "Looker API 3.1"],
keywords=["Looker", "Looker API", "looker_sdk", "Looker API 3.1", "Looker API 4.0"],
name=NAME,
package_data={"looker_sdk": ["py.typed", "looker_sdk/looker-sample.ini"]},
packages=find_packages(),
Expand Down

0 comments on commit 7939a73

Please sign in to comment.