Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove python setup.py author_email #787

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Conversation

joeldodge79
Copy link
Contributor

we no longer have support@looker.com and this field only accepts
a valid email address. sadly twine check does not catch this error
yet, hopefully it will some day.

Factored the twine check out of the unit matrix: it only needs to run once

we no longer have support@looker.com and this field only accepts
a valid email address. sadly twine check does not catch this error
yet, hopefully it will some day.

Factored the twine check out of the unit matrix: it only needs to run once
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

Python Tests

  10 files    10 suites   2m 3s ⏱️
140 tests 140 ✔️ 0 💤 0 ❌
788 runs  788 ✔️ 0 💤 0 ❌

Results for commit 18dd0a0.

Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeldodge79 joeldodge79 merged commit 7939a73 into main Aug 9, 2021
@joeldodge79 joeldodge79 deleted the fix-python-setup.py branch August 9, 2021 15:36
@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants