Skip to content

Commit

Permalink
ci: change workflows to use reusable action for looker versions (#1018)
Browse files Browse the repository at this point in the history
* ci: change workflows to use reusable action for looker versions

* fix: change supported-versions@v0.0.1 to @main

  Using a particular version here is a mistake since
  this would need to change for every new looker release.
  Instead use @main so that the supported-versions
  action will always use the latest version.
  • Loading branch information
drstrangelooker authored Mar 14, 2022
1 parent 0b45a6b commit a9f62bb
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 17 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/go-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,10 @@ jobs:
name: ${{ env.JUNIT_ARTIFACT_DIR }}
path: ${{ env.JUNIT_OUTPUT_DIR }}

setup:
uses: looker-open-source/reusable-actions/.github/workflows/supported-versions.yml@main
integration:
needs: unit
needs: [setup,unit]
name: Integration - ${{ matrix.os }} / Looker.${{ matrix.looker }}
env:
GO_JUNIT_OUTPUT_NAME: ${{ matrix.os }}.Looker-${{ matrix.looker }}.gointegration.xml
Expand All @@ -78,10 +80,8 @@ jobs:
matrix:
os:
- ubuntu
looker:
- '21_18'
- '21_20'
- '22_0'
looker: ${{ fromJson(needs.setup.outputs.matrix_json) }}

# TODO uncomment `include:` when either macos or windows works to satisfaction.
#include:
# TODO: macos matrix leg is functional but it takes ~20 minutes (compared
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/python-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,10 @@ jobs:
name: python-test-results
path: python/results/

setup:
uses: looker-open-source/reusable-actions/.github/workflows/supported-versions.yml@main
integration:
needs: unit
needs: [unit,setup]
name: Integration - ${{ matrix.os }} / Looker.${{ matrix.looker }}
env:
TOX_JUNIT_OUTPUT_NAME: ${{ matrix.os }}.Looker-${{ matrix.looker }}.py3.x
Expand All @@ -109,11 +111,8 @@ jobs:
matrix:
os:
- ubuntu
looker:
- '21_18'
- '21_20'
- '22_0'
- '22_2'
looker: ${{ fromJson(needs.setup.outputs.matrix_json) }}

# TODO uncomment `include:` when either macos or windows works to satisfaction.
#include:
# TODO: macos matrix leg is functional but it takes ~20 minutes (compared
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/tssdk-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,10 @@ jobs:
name: tssdk-test-results
path: results/tssdk

setup:
uses: looker-open-source/reusable-actions/.github/workflows/supported-versions.yml@main
integration:
needs: unit
needs: [unit,setup]
name: Integration - ${{ matrix.os }} / Node.${{ matrix.node-version }} / Looker.${{ matrix.looker }}
env:
JEST_JUNIT_OUTPUT_DIR: results/tssdk
Expand All @@ -117,11 +119,7 @@ jobs:
node-version: [12.x]
os:
- ubuntu
looker:
- '21_18'
- '21_20'
- '22_0'
- '22_2'
looker: ${{ fromJson(needs.setup.outputs.matrix_json) }}

steps:
- name: Repo Checkout
Expand Down

0 comments on commit a9f62bb

Please sign in to comment.