Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: change workflows to use reusable action for looker versions #1018

Merged
merged 2 commits into from
Mar 14, 2022
Merged

ci: change workflows to use reusable action for looker versions #1018

merged 2 commits into from
Mar 14, 2022

Conversation

drstrangelooker
Copy link
Collaborator

The looker versions for CI are all in one place now.

@drstrangelooker drstrangelooker force-pushed the drstrangelove/reusable-worflow-versions branch from ee9b725 to b558d50 Compare March 11, 2022 01:07
@github-actions
Copy link
Contributor

Go Tests

  7 files    7 suites   1m 23s ⏱️
34 tests 34 ✔️ 0 💤 0 ❌
80 runs  80 ✔️ 0 💤 0 ❌

Results for commit b558d50.

@github-actions
Copy link
Contributor

Python Tests

  12 files    12 suites   3m 3s ⏱️
143 tests 143 ✔️ 0 💤 0 ❌
927 runs  927 ✔️ 0 💤 0 ❌

Results for commit b558d50.

@github-actions
Copy link
Contributor

Typescript Tests

    8 files    77 suites   5m 39s ⏱️
169 tests 164 ✔️   4 💤 1 ❌
615 runs  594 ✔️ 20 💤 1 ❌

For more details on these failures, see this check.

Results for commit b558d50.

jkaster
jkaster previously approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice improvement

@drstrangelooker
Copy link
Collaborator Author

@jkaster Typescript tests fail with 22.4 on an issue with strings passed where interferes are expected.

I'm thinking that I'll override the required check then we'll do a separate PR to change the tests.

@drstrangelooker
fix: change supported-versions@v0.0.1 to @main
3842e71 
  Using a particular version here is a mistake since
  this would need to change for every new looker release.
  Instead use @main so that the supported-versions
  action will always use the latest version.
@drstrangelooker
Copy link
Collaborator Author

@jkaster I backed the supported-versions array to ["21.18", "21.20", "22.0", "22.2"] for now.

I also changed the action to reference supported-versions@main instead of supported-versions@v0.0.1. I realized if I used a specific tag, I would need to change sdk-codegen every time the version array was changed. That was the exact opposite of what we wanted. So I needed to reference the main branch instead.

I also created tags supported-versions-v22.2 and supported-versions-v22.4 to allow a caller to specify the max version they want to deal with.

@jkaster
Copy link
Contributor

jkaster commented Mar 14, 2022

@jkaster Typescript tests fail with 22.4 on an issue with strings passed where interferes are expected.

I think you mean "integers" above, and I'll look at that.

jkaster
jkaster approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@drstrangelooker drstrangelooker merged commit a9f62bb into main Mar 14, 2022
@drstrangelooker drstrangelooker deleted the drstrangelove/reusable-worflow-versions branch March 14, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaster jkaster jkaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drstrangelooker @jkaster