Cannot create User / Group Attributes with Kotlin SDK if User Attribute is not hidden

[frankspeak]

With the Kotlin SDK, running against Looker 7.20.12, user attribute operations fail if the user attribute is not hidden.

For create_user_attribute() for example, this works...

WriteUserAttribute(name=git_password, label=Git Password, type=string, default_value=, value_is_hidden=true, user_can_view=true, user_can_edit=true, hidden_value_domain_whitelist=https://foobar.com/*)

… but this fails with a 422…

WriteUserAttribute(name=git_username, label=Git Username, type=string, default_value=, value_is_hidden=false, user_can_view=true, user_can_edit=true, hidden_value_domain_whitelist=null)

Similiar for set_user_attribute_group_values, this works...

[UserAttributeGroupValue(can=null, id=null, group_id=4, user_attribute_id=38, value_is_hidden=true, rank=null, value=1.2.3.4)]

... but this fails with a 500...

[UserAttributeGroupValue(can=null, id=null, group_id=4, user_attribute_id=28, value_is_hidden=false, rank=null, value=1.2.3.4)]

Testing with the API, I think the issue may be caused by the SDK always sending the hidden_value_domain_whitelist, even if the value is not hidden.

API Docs:

• Create User Attribute
• Set User Attribute Group Values

[jkaster]

Thanks for the report. We'll need to investigate the 422 scenario, and we also never want users to encounter 500 errors from calling our API.

[frankspeak]

After upgrading to looker 21.0.34, looks like set_user_attribute_group_values() now succeeds - but create_user_attribute() is still failing.

[jkaster]

Thanks for the update @frankspeak. I should be able to look at this more in the next few days.

[jkaster]

The error being obscured in the Kotlin SDK is:

hidden_value_domain_whitelist must be a comma-separated list of urls with optional wildcards, like "https://example.com*,localhost:9932", with bare wildcards not allowed (code: invalid)

[frankspeak]

@jkaster , not sure I understand - the problem only occurs when the value is not hidden - why is the hidden_domain_whitelist required? Were you able to get this SDK method to work with non-hidden user attributes?

[jkaster]

Whoops, sorry I forgot to mention an important bit:

When the parameter value_is_hidden=false you do not have to provide the parameter and value for hidden_value_domain_whitelist and the call works as expected.

[frankspeak]

I'm using the SDK and hidden_value_domain_whitelist is a parameter of WriteUserAttribute.

I tried null, empty strings etc. However, it looks like the SDK always sends it and that's the bug.

As in the description above, if you don't specify it in the web UI, everything works.

[jkaster]

Reopening because of the Kotlin SDK friction for null properties.

[jkaster]

@frankspeak this should definitely be fixed with #601 now. That PR should get merged today

[jkaster]

Thanks for your patience and perseverance @frankspeak. Let me know if this doesn't solve the problem for you.

[frankspeak]

Thanks @jkaster - after the fix, we appear to be in business.

[jkaster]

Thanks for the confirmation!

…

On Tue, Apr 20, 2021, 8:39 PM frankspeak ***@***.***> wrote: Thanks @jkaster <https://github.com/jkaster> - after the fix, we appear to be in business. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#544 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABORGAQFJ5NVD6HHIADY5IDTJZCINANCNFSM42GAOE5A> .