fix: error handling for TS SDK, GSon body serialization for Kotlin SDK #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For diagnosing #544 We have an outstanding feature request to improve analysis of Kotlin SDK errors, but this documents the encountered error in the Typescript SDK test, which has better error handling API Explorer and the existing Looker API Docs UI can be used to see what the actual 422 error is
jkaster
requested review from
bryans99,
joeldodge79,
DucarrougeR and
josephaxisa
This comment has been minimized.
This comment has been minimized.
Gson strips `null` properties from the JSON body so create_user_attribute no longer throws an error Updated test to verify correct behavior and report an error if the call fails Fixes #544
jkaster
changed the title
Test Results 7 files 73 suites 4m 8s ⏱️ Results for commit 881853b. |
joeldodge79
suggested changes
Apr 20, 2021
There was a problem hiding this comment.
I'm kind of feeling like this should be two separate PRs for the sake of cleaner changelog entries? Granted right now we're not maintaining a kotlin changelog (hopefully will be soon). As written, the packages/sdk/CHANGELOG.md entry will be:
### Fixes
* error handling for TS SDK, GSon body serialization for Kotlin SDKBut if you're ok with that then we can merge as-is.
|
The PR was based on analyzing and understanding what was happening with the endpoint. I could make separate PRs but since the changelog won't get processed for the Kotlin SDK right now I'd rather not spend the time. |
joeldodge79
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an outstanding feature request to improve analysis of Kotlin SDK errors, but this documents the encountered error in the Typescript SDK test, which has better error handling
API Explorer and the existing Looker API Docs UI can also be used to see what the actual 422 error is
Fixes #544 🦕