Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error handling for TS SDK, GSon body serialization for Kotlin SDK #601

Merged
merged 3 commits into from
Apr 20, 2021
Merged

fix: error handling for TS SDK, GSon body serialization for Kotlin SDK #601

merged 3 commits into from
Apr 20, 2021

Commits on Apr 19, 2021

  1. chore: test create_user_attribute 

    For diagnosing #544

We have an outstanding feature request to improve analysis of Kotlin SDK errors, but this documents the encountered error in the Typescript SDK test, which has better error handling

API Explorer and the existing Looker API Docs UI can be used to see what the actual 422 error is
    @jkaster
    jkaster committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    23d6f60 View commit details
    Browse the repository at this point in the history

  2. Clarifying Kotlin test comment

    @jkaster
    jkaster committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    9e15cf1 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. fix: Use Gson to serialize Kotlin SDK request bodies 

    Gson strips `null` properties from the JSON body so create_user_attribute no longer throws an error

Updated test to verify correct behavior and report an error if the call fails

Fixes #544
    @jkaster
    jkaster committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    881853b View commit details
    Browse the repository at this point in the history