Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Property names with special characters in Kotlin SDK #837

Closed
mistryrakesh opened this issue Sep 28, 2021 · 0 comments · Fixed by #838
Closed

fix: Property names with special characters in Kotlin SDK #837

mistryrakesh opened this issue Sep 28, 2021 · 0 comments · Fixed by #838
Assignees
@mistryrakesh

Comments

@mistryrakesh
Copy link
Contributor

Fix generation of property names with special characters. This bug got introduced due to #825.
@mistryrakesh mistryrakesh self-assigned this Sep 28, 2021
@mistryrakesh mistryrakesh mentioned this issue Sep 28, 2021
Merged
3 tasks
jkaster pushed a commit that referenced this issue Sep 28, 2021
@mistryrakesh
fix: Property names with special characters in Kotlin SDK (#838)
40b6b24 
This PR fixes generation of kotlin classes which handle properties having special characters.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/looker-open-source/sdk-codegen/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Appropriate docs were updated (if necessary)

Fixes #837 🦕
jkaster added a commit that referenced this issue Sep 30, 2021
@jkaster @mistryrakesh
feat: validate request bodies (#834)
cc13871 
* feat: request body validation before Run

also fixed RunIt form update when methods are changed

* fixed e2e tests but lost type tag tests

Need to expand e2e testing anyway

* moving prettier to scripts package

sadly, no version of it can run in the browser

* chore: refreshing hackathon app (#835)

* chore: refreshing hackathon app

also

 - updated TypeScript
 - updated Prettier
 - bumped ts-jest
 - updated ts-node

* Fixing APIX CI workflow

* feat: Update Kotlin SDK to use Gson instead of Jackson (#836)

* Updated Kotlin SDK to use Gson for serialization/deserialization.
* Added type adapter for AuthToken to handle constructor calls.
* Added smoke test to check deserialization ignores unknown properties.

* fix type resolution in various test:sdk suites

* fix: Property names with special characters in Kotlin SDK (#838)

This PR fixes generation of kotlin classes which handle properties having special characters.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/looker-open-source/sdk-codegen/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Appropriate docs were updated (if necessary)

Fixes #837 🦕

* added form encoded body validation

* allow . and - in encoded argument names

Co-authored-by: Rakesh Mistry <rakesh.dta@gmail.com>
Co-authored-by: Rakesh Mistry <rakeshmistry@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mistryrakesh mistryrakesh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Property names with special characters in Kotlin SDK looker-open-source/sdk-codegen
1 participant
@mistryrakesh