-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update Kotlin SDK to use Gson instead of Jackson #836
Conversation
Codegen Tests 1 files 6 suites 59s ⏱️ Results for commit e31ccff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great update. Nice to have cleaner and more flexible code.
bin/smoke kotlin
passes.
Can you add a test that verifies the graceful handling of unknown fields?
Hey @jkaster thanks for reviewing! I have added a smoke test ( Using the Jackson deserializer the test fails with error:
|
@mistryrakesh This is great stuff! I really appreciate your contributions here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! It's great to have better resilience for the Kotlin SDK.
This comment has been minimized.
This comment has been minimized.
* feat: request body validation before Run also fixed RunIt form update when methods are changed * fixed e2e tests but lost type tag tests Need to expand e2e testing anyway * moving prettier to scripts package sadly, no version of it can run in the browser * chore: refreshing hackathon app (#835) * chore: refreshing hackathon app also - updated TypeScript - updated Prettier - bumped ts-jest - updated ts-node * Fixing APIX CI workflow * feat: Update Kotlin SDK to use Gson instead of Jackson (#836) * Updated Kotlin SDK to use Gson for serialization/deserialization. * Added type adapter for AuthToken to handle constructor calls. * Added smoke test to check deserialization ignores unknown properties. * fix type resolution in various test:sdk suites * fix: Property names with special characters in Kotlin SDK (#838) This PR fixes generation of kotlin classes which handle properties having special characters. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/looker-open-source/sdk-codegen/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Appropriate docs were updated (if necessary) Fixes #837 🦕 * added form encoded body validation * allow . and - in encoded argument names Co-authored-by: Rakesh Mistry <rakesh.dta@gmail.com> Co-authored-by: Rakesh Mistry <rakeshmistry@google.com>
This PR updates the kotlin SDK to use Gson instead of Jackson for deserialization (We were already using gson to serialize).
This fixes:
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #825 🦕