Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SDK language selection as URL search parameter #1123

Merged
merged 31 commits into from
Aug 9, 2022

Conversation

patnir41
Copy link
Contributor

@patnir41 patnir41 commented Jul 22, 2022

Upon having a selected SDK language in the API Explorer, an 'sdk' search parameter will be present on the URL that will allow developers to share method and type descriptions with the appropriate language automatically selected.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@patnir41 patnir41 marked this pull request as ready for review July 26, 2022 23:50
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

APIX Tests

    1 files  ±  0    82 suites  +1   7m 44s ⏱️ + 2m 9s
357 tests +24  344 ✔️ +24  13 💤 ±0  0 ❌ ±0 
373 runs  +24  360 ✔️ +24  13 💤 ±0  0 ❌ ±0 

Results for commit 1898cc2. ± Comparison against base commit d6e0c37.

This pull request removes 2 and adds 26 tests. Note that renamed tests count towards both.
Navigate clears existing params when given params are an empty object ‑ Navigate clears existing params when given params are an empty object
SdkLanguageSelector it stores the selected language in localStorage ‑ SdkLanguageSelector it stores the selected language in localStorage
Navigate appends parameters when object is passed in with existing parameters ‑ Navigate appends parameters when object is passed in with existing parameters
Navigate null query params are removed ‑ Navigate null query params are removed
SDK Language Utils allSdkLanguages gets all sdk languages ‑ SDK Language Utils allSdkLanguages gets all sdk languages
SDK Language Utils getAliasByLanguage finds alias for language All ‑ SDK Language Utils getAliasByLanguage finds alias for language All
SDK Language Utils getAliasByLanguage finds alias for language C# ‑ SDK Language Utils getAliasByLanguage finds alias for language C#
SDK Language Utils getAliasByLanguage finds alias for language Go ‑ SDK Language Utils getAliasByLanguage finds alias for language Go
SDK Language Utils getAliasByLanguage finds alias for language Kotlin ‑ SDK Language Utils getAliasByLanguage finds alias for language Kotlin
SDK Language Utils getAliasByLanguage finds alias for language Python ‑ SDK Language Utils getAliasByLanguage finds alias for language Python
SDK Language Utils getAliasByLanguage finds alias for language Swift ‑ SDK Language Utils getAliasByLanguage finds alias for language Swift
SDK Language Utils getAliasByLanguage finds alias for language TypeScript ‑ SDK Language Utils getAliasByLanguage finds alias for language TypeScript
…

Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress. I'm looking forward to this landing.

packages/api-explorer/src/utils/sdkLanguage.ts Outdated Show resolved Hide resolved
packages/api-explorer/src/utils/sdkLanguage.ts Outdated Show resolved Hide resolved
packages/api-explorer/src/ApiExplorer.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

APIX Tests

    1 files  ±  0    82 suites  +1   5m 56s ⏱️ +21s
356 tests +23  343 ✔️ +23  13 💤 ±0  0 ❌ ±0 
372 runs  +23  359 ✔️ +23  13 💤 ±0  0 ❌ ±0 

Results for commit 141ee1b. ± Comparison against base commit d6e0c37.

This pull request removes 2 and adds 25 tests. Note that renamed tests count towards both.
Navigate clears existing params when given params are an empty object ‑ Navigate clears existing params when given params are an empty object
SdkLanguageSelector it stores the selected language in localStorage ‑ SdkLanguageSelector it stores the selected language in localStorage
Navigate appends parameters when object is passed in with existing parameters ‑ Navigate appends parameters when object is passed in with existing parameters
Navigate null query params are removed ‑ Navigate null query params are removed
SDK Language Utils allSdkLanguages gets all sdk languages ‑ SDK Language Utils allSdkLanguages gets all sdk languages
SDK Language Utils getSdkLanguage it finds alias for language all ‑ SDK Language Utils getSdkLanguage it finds alias for language all
SDK Language Utils getSdkLanguage it finds alias for language cs ‑ SDK Language Utils getSdkLanguage it finds alias for language cs
SDK Language Utils getSdkLanguage it finds alias for language go ‑ SDK Language Utils getSdkLanguage it finds alias for language go
SDK Language Utils getSdkLanguage it finds alias for language kt ‑ SDK Language Utils getSdkLanguage it finds alias for language kt
SDK Language Utils getSdkLanguage it finds alias for language py ‑ SDK Language Utils getSdkLanguage it finds alias for language py
SDK Language Utils getSdkLanguage it finds alias for language swift ‑ SDK Language Utils getSdkLanguage it finds alias for language swift
SDK Language Utils getSdkLanguage it finds alias for language ts ‑ SDK Language Utils getSdkLanguage it finds alias for language ts
…

Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments since there's pending feedback requested from others

packages/api-explorer/src/ApiExplorer.tsx Show resolved Hide resolved
packages/api-explorer/src/components/DocSDKs/DocSDKs.tsx Outdated Show resolved Hide resolved
const generators = getGenerators(api)
const [item, setItem] = useState(method ? noComment(method) : type!)
const [declarations, setDeclarations] = useState(
getDeclarations(generators, sdkLanguage, item)
getDeclarations(generators, sdk.language, item)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handy and simple. I like the composed value.

@@ -151,7 +151,7 @@ describe('Diff Scene', () => {
page.evaluate((el) => el.innerText.match(/^[a-z_]*/)[0], resultCard)
)
)
expect(page1Methods).toHaveLength(15)
expect(page1Methods).toHaveLength(16)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was failing in main, fixed so that it is up to date and accurately reflecting new additional method.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

APIX Tests

    1 files  ±  0    82 suites  +1   5m 49s ⏱️ +14s
356 tests +23  343 ✔️ +23  13 💤 ±0  0 ❌ ±0 
372 runs  +23  359 ✔️ +23  13 💤 ±0  0 ❌ ±0 

Results for commit bf28b9b. ± Comparison against base commit d6e0c37.

This pull request removes 2 and adds 25 tests. Note that renamed tests count towards both.
Navigate clears existing params when given params are an empty object ‑ Navigate clears existing params when given params are an empty object
SdkLanguageSelector it stores the selected language in localStorage ‑ SdkLanguageSelector it stores the selected language in localStorage
Navigate appends parameters when object is passed in with existing parameters ‑ Navigate appends parameters when object is passed in with existing parameters
Navigate null query params are removed ‑ Navigate null query params are removed
SDK Language Utils allSdkLanguages gets all sdk languages ‑ SDK Language Utils allSdkLanguages gets all sdk languages
SDK Language Utils getSdkLanguage it finds alias for language all ‑ SDK Language Utils getSdkLanguage it finds alias for language all
SDK Language Utils getSdkLanguage it finds alias for language cs ‑ SDK Language Utils getSdkLanguage it finds alias for language cs
SDK Language Utils getSdkLanguage it finds alias for language go ‑ SDK Language Utils getSdkLanguage it finds alias for language go
SDK Language Utils getSdkLanguage it finds alias for language kt ‑ SDK Language Utils getSdkLanguage it finds alias for language kt
SDK Language Utils getSdkLanguage it finds alias for language py ‑ SDK Language Utils getSdkLanguage it finds alias for language py
SDK Language Utils getSdkLanguage it finds alias for language swift ‑ SDK Language Utils getSdkLanguage it finds alias for language swift
SDK Language Utils getSdkLanguage it finds alias for language ts ‑ SDK Language Utils getSdkLanguage it finds alias for language ts
…

@@ -164,6 +164,9 @@ describe('API Explorer', () => {
'Kotlin'
)
await expect(page).toMatchElement('h3', { text: 'Kotlin Declaration' })
await page.evaluate(() => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observed this cause unpredictable behavior, new commit will move this to an afterEach within this test block.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the afterEach but this is still here. Is this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most recent commit maintains the intended structure, there are two afterEach's that handle the clearing of local storage.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

APIX Tests

    1 files  ±  0    82 suites  +1   7m 5s ⏱️ + 1m 30s
356 tests +23  343 ✔️ +23  13 💤 ±0  0 ❌ ±0 
372 runs  +23  359 ✔️ +23  13 💤 ±0  0 ❌ ±0 

Results for commit 3727b65. ± Comparison against base commit d6e0c37.

This pull request removes 2 and adds 25 tests. Note that renamed tests count towards both.
Navigate clears existing params when given params are an empty object ‑ Navigate clears existing params when given params are an empty object
SdkLanguageSelector it stores the selected language in localStorage ‑ SdkLanguageSelector it stores the selected language in localStorage
Navigate appends parameters when object is passed in with existing parameters ‑ Navigate appends parameters when object is passed in with existing parameters
Navigate null query params are removed ‑ Navigate null query params are removed
SDK Language Utils allSdkLanguages gets all sdk languages ‑ SDK Language Utils allSdkLanguages gets all sdk languages
SDK Language Utils getSdkLanguage it finds alias for language all ‑ SDK Language Utils getSdkLanguage it finds alias for language all
SDK Language Utils getSdkLanguage it finds alias for language cs ‑ SDK Language Utils getSdkLanguage it finds alias for language cs
SDK Language Utils getSdkLanguage it finds alias for language go ‑ SDK Language Utils getSdkLanguage it finds alias for language go
SDK Language Utils getSdkLanguage it finds alias for language kt ‑ SDK Language Utils getSdkLanguage it finds alias for language kt
SDK Language Utils getSdkLanguage it finds alias for language py ‑ SDK Language Utils getSdkLanguage it finds alias for language py
SDK Language Utils getSdkLanguage it finds alias for language swift ‑ SDK Language Utils getSdkLanguage it finds alias for language swift
SDK Language Utils getSdkLanguage it finds alias for language ts ‑ SDK Language Utils getSdkLanguage it finds alias for language ts
…

@@ -164,6 +164,9 @@ describe('API Explorer', () => {
'Kotlin'
)
await expect(page).toMatchElement('h3', { text: 'Kotlin Declaration' })
await page.evaluate(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the afterEach but this is still here. Is this intended?

const paramMatchesSdk =
!sdkParam.localeCompare(sdk.alias, 'en', { sensitivity: 'base' }) ||
!sdkParam.localeCompare(sdk.language, 'en', { sensitivity: 'base' })
if (sdkParam && sdk && paramMatchesSdk) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is sdk redundant in this check? Also perhaps sdkParam && validSdkParam would be more descriptive here.

Copy link
Contributor Author

@patnir41 patnir41 Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we can get by with just validSdkParam for the conditional check, as it will encapsulate all situations. If there is no sdk parameter, then sdkParam will be '' and the comparison will be false. If there is a parameter then we need to know if it matches what was found in findSdk when we searched. See new change.

packages/api-explorer/src/utils/sdkLanguage.spec.ts Outdated Show resolved Hide resolved
packages/api-explorer/src/utils/sdkLanguage.spec.ts Outdated Show resolved Hide resolved
packages/api-explorer/src/ApiExplorer.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

APIX Tests

    1 files  ±  0    82 suites  +1   5m 25s ⏱️ -10s
357 tests +24  344 ✔️ +24  13 💤 ±0  0 ❌ ±0 
373 runs  +24  360 ✔️ +24  13 💤 ±0  0 ❌ ±0 

Results for commit d8c3f51. ± Comparison against base commit d6e0c37.

This pull request removes 2 and adds 26 tests. Note that renamed tests count towards both.
Navigate clears existing params when given params are an empty object ‑ Navigate clears existing params when given params are an empty object
SdkLanguageSelector it stores the selected language in localStorage ‑ SdkLanguageSelector it stores the selected language in localStorage
Navigate appends parameters when object is passed in with existing parameters ‑ Navigate appends parameters when object is passed in with existing parameters
Navigate null query params are removed ‑ Navigate null query params are removed
SDK Language Utils allSdkLanguages gets all sdk languages ‑ SDK Language Utils allSdkLanguages gets all sdk languages
SDK Language Utils findSdk it finds alias for language all ‑ SDK Language Utils findSdk it finds alias for language all
SDK Language Utils findSdk it finds alias for language cs ‑ SDK Language Utils findSdk it finds alias for language cs
SDK Language Utils findSdk it finds alias for language go ‑ SDK Language Utils findSdk it finds alias for language go
SDK Language Utils findSdk it finds alias for language kt ‑ SDK Language Utils findSdk it finds alias for language kt
SDK Language Utils findSdk it finds alias for language py ‑ SDK Language Utils findSdk it finds alias for language py
SDK Language Utils findSdk it finds alias for language swift ‑ SDK Language Utils findSdk it finds alias for language swift
SDK Language Utils findSdk it finds alias for language ts ‑ SDK Language Utils findSdk it finds alias for language ts
…

@josephaxisa josephaxisa self-requested a review August 8, 2022 23:31
Copy link
Contributor

@josephaxisa josephaxisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks Niral!

Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

APIX Tests

    1 files    82 suites   7m 18s ⏱️
357 tests 344 ✔️ 13 💤 0 ❌
373 runs  360 ✔️ 13 💤 0 ❌

Results for commit 88c99a1.

@patnir41 patnir41 merged commit ae59b95 into main Aug 9, 2022
@patnir41 patnir41 deleted the patnir41/sdk-sharing-url branch August 9, 2022 17:15
@github-actions

This comment has been minimized.

jkaster pushed a commit that referenced this pull request Aug 12, 2022
* SDK parameter in URL, new 'sdk' in as part of queryparams

* SDK in URL drives state in the APIExplorer

* Choosing 'All' removes parameter from URL

* Unit tests to cover functionality

* Refactoring e2e tests to pass
jkaster pushed a commit that referenced this pull request Sep 21, 2022
🤖 I have created a release \*beep\* \*boop\*
---
<details><summary>sdk-codegen-all: 2.8.0</summary>


### Features

* ability to share a tag scene with a filter applied ([#1142](https://www.github.com/looker-open-source/sdk-codegen/issues/1142)) ([135dce3](https://www.github.com/looker-open-source/sdk-codegen/commit/135dce3a3bf75ad79525a81b2e848e118cc340e4))
* capture error details for the Kotlin SDK ([#1137](https://www.github.com/looker-open-source/sdk-codegen/issues/1137)) ([9909206](https://www.github.com/looker-open-source/sdk-codegen/commit/9909206e326b60a4465dbd50fbcf0ddb71749ae7))
* change diff scene route ([#1159](https://www.github.com/looker-open-source/sdk-codegen/issues/1159)) ([180cf20](https://www.github.com/looker-open-source/sdk-codegen/commit/180cf204f767474a76ad7de2ee6fb5171f910eb0))
* copy link button for search ([#1120](https://www.github.com/looker-open-source/sdk-codegen/issues/1120)) ([d6e0c37](https://www.github.com/looker-open-source/sdk-codegen/commit/d6e0c37ae36b1ff4129cf3bb30f8462f4aa49b0d))
* error code document retrieval ([#1136](https://www.github.com/looker-open-source/sdk-codegen/issues/1136)) ([305966b](https://www.github.com/looker-open-source/sdk-codegen/commit/305966b943e8dc6fde08d58cbb36febcbae5733f))
* error document retrieval in API Explorer ([#1161](https://www.github.com/looker-open-source/sdk-codegen/issues/1161)) ([89a94e1](https://www.github.com/looker-open-source/sdk-codegen/commit/89a94e167b8a3e1aa662c0b5de7c585b3eac2f13))
* error documentation redirect and support for detailed error content ([#1167](https://www.github.com/looker-open-source/sdk-codegen/issues/1167)) ([5b4fc5b](https://www.github.com/looker-open-source/sdk-codegen/commit/5b4fc5b91e05ed4ccd9090724e4ac3f506b541fd))
* generate SDKs for Looker 22.12 ([#1175](https://www.github.com/looker-open-source/sdk-codegen/issues/1175)) ([6f427a7](https://www.github.com/looker-open-source/sdk-codegen/commit/6f427a71dd30669afc901a47418decd59b977a7a))
* generate SDKs for Looker 22.14 ([#1176](https://www.github.com/looker-open-source/sdk-codegen/issues/1176)) ([328d3e5](https://www.github.com/looker-open-source/sdk-codegen/commit/328d3e5710fc80caf5691b8d3ea3d8b8db358ad6))
* regenerate Looker 22.12 SDKs ([#1177](https://www.github.com/looker-open-source/sdk-codegen/issues/1177)) ([b3a9b7b](https://www.github.com/looker-open-source/sdk-codegen/commit/b3a9b7bfff6366abce4802b819d19d00ee00cd60))
* SDK language selection as URL search parameter ([#1123](https://www.github.com/looker-open-source/sdk-codegen/issues/1123)) ([ae59b95](https://www.github.com/looker-open-source/sdk-codegen/commit/ae59b956a5f42dcdd5aa9b4c3d0da1836129a932))


### Bug Fixes

* add error detail handling for Python SDK ([#1170](https://www.github.com/looker-open-source/sdk-codegen/issues/1170)) ([0db7157](https://www.github.com/looker-open-source/sdk-codegen/commit/0db715768deedbf3290cd29c5aa788d9546e64f0))
* add ErrorDoc class to the Kotlin SDK ([#1143](https://www.github.com/looker-open-source/sdk-codegen/issues/1143)) ([20fbd31](https://www.github.com/looker-open-source/sdk-codegen/commit/20fbd31939e0ff88b9be3fdcf260176069143925))
* add field details for SDK error ([#1134](https://www.github.com/looker-open-source/sdk-codegen/issues/1134)) ([ef1c96d](https://www.github.com/looker-open-source/sdk-codegen/commit/ef1c96d9bc1ae7c27b6ec4b07c7d33f04930d2a7))
* add field details for SDK error ([#1141](https://www.github.com/looker-open-source/sdk-codegen/issues/1141)) ([9af3092](https://www.github.com/looker-open-source/sdk-codegen/commit/9af30928417e773b6e23a539012bdf9381490a13))
* DiffScene Page Displays Accurate Number of Diff Entries ([#1163](https://www.github.com/looker-open-source/sdk-codegen/issues/1163)) ([ee46932](https://www.github.com/looker-open-source/sdk-codegen/commit/ee469326783377a4ba382e1df915a30f1c503fd6))
* IErrorDetail fields should not be null ([#1146](https://www.github.com/looker-open-source/sdk-codegen/issues/1146)) ([44274b4](https://www.github.com/looker-open-source/sdk-codegen/commit/44274b4a3974ff4b946a9a0f3209c70cd77b245e))
* rerendering issues on DiffScene options change ([#1168](https://www.github.com/looker-open-source/sdk-codegen/issues/1168)) ([a4ac3bc](https://www.github.com/looker-open-source/sdk-codegen/commit/a4ac3bcf2b03ef427fe0fd13c72d1d7e3e939f90))
* whitespace under CollapserCard child components ([#1162](https://www.github.com/looker-open-source/sdk-codegen/issues/1162)) ([89fbf29](https://www.github.com/looker-open-source/sdk-codegen/commit/89fbf2911701b598bf9d673cef00e790a1bc8207))
</details>
<details><summary>@looker/api-explorer: 0.9.37</summary>


### Features

* ability to share a tag scene with a filter applied ([#1142](https://www.github.com/looker-open-source/sdk-codegen/issues/1142)) ([135dce3](https://www.github.com/looker-open-source/sdk-codegen/commit/135dce3a3bf75ad79525a81b2e848e118cc340e4))
* change diff scene route ([#1159](https://www.github.com/looker-open-source/sdk-codegen/issues/1159)) ([180cf20](https://www.github.com/looker-open-source/sdk-codegen/commit/180cf204f767474a76ad7de2ee6fb5171f910eb0))
* copy link button for search ([#1120](https://www.github.com/looker-open-source/sdk-codegen/issues/1120)) ([d6e0c37](https://www.github.com/looker-open-source/sdk-codegen/commit/d6e0c37ae36b1ff4129cf3bb30f8462f4aa49b0d))
* error document retrieval in API Explorer ([#1161](https://www.github.com/looker-open-source/sdk-codegen/issues/1161)) ([89a94e1](https://www.github.com/looker-open-source/sdk-codegen/commit/89a94e167b8a3e1aa662c0b5de7c585b3eac2f13))
* error documentation redirect and support for detailed error content ([#1167](https://www.github.com/looker-open-source/sdk-codegen/issues/1167)) ([5b4fc5b](https://www.github.com/looker-open-source/sdk-codegen/commit/5b4fc5b91e05ed4ccd9090724e4ac3f506b541fd))
* SDK language selection as URL search parameter ([#1123](https://www.github.com/looker-open-source/sdk-codegen/issues/1123)) ([ae59b95](https://www.github.com/looker-open-source/sdk-codegen/commit/ae59b956a5f42dcdd5aa9b4c3d0da1836129a932))


### Bug Fixes

* DiffScene Page Displays Accurate Number of Diff Entries ([#1163](https://www.github.com/looker-open-source/sdk-codegen/issues/1163)) ([ee46932](https://www.github.com/looker-open-source/sdk-codegen/commit/ee469326783377a4ba382e1df915a30f1c503fd6))
* rerendering issues on DiffScene options change ([#1168](https://www.github.com/looker-open-source/sdk-codegen/issues/1168)) ([a4ac3bc](https://www.github.com/looker-open-source/sdk-codegen/commit/a4ac3bcf2b03ef427fe0fd13c72d1d7e3e939f90))
* whitespace under CollapserCard child components ([#1162](https://www.github.com/looker-open-source/sdk-codegen/issues/1162)) ([89fbf29](https://www.github.com/looker-open-source/sdk-codegen/commit/89fbf2911701b598bf9d673cef00e790a1bc8207))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/code-editor bumped from ^0.1.23 to ^0.1.24
    * @looker/extension-utils bumped from ^0.1.13 to ^0.1.14
    * @looker/run-it bumped from ^0.9.36 to ^0.9.37
    * @looker/sdk bumped from ^22.10.1 to ^22.12.1
    * @looker/sdk-codegen bumped from ^21.7.0 to ^21.7.1
    * @looker/sdk-rtl bumped from ^21.3.4 to ^21.4.0
  * devDependencies
    * @looker/sdk-codegen-scripts bumped from ^21.4.2 to ^21.4.3
    * @looker/sdk-node bumped from ^22.10.1 to ^22.12.1
</details>
<details><summary>@looker/code-editor: 0.1.24</summary>


### Features

* error document retrieval in API Explorer ([#1161](https://www.github.com/looker-open-source/sdk-codegen/issues/1161)) ([89a94e1](https://www.github.com/looker-open-source/sdk-codegen/commit/89a94e167b8a3e1aa662c0b5de7c585b3eac2f13))
* error documentation redirect and support for detailed error content ([#1167](https://www.github.com/looker-open-source/sdk-codegen/issues/1167)) ([5b4fc5b](https://www.github.com/looker-open-source/sdk-codegen/commit/5b4fc5b91e05ed4ccd9090724e4ac3f506b541fd))


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @looker/sdk-codegen bumped from ^21.7.0 to ^21.7.1
</details>
<details><summary>@looker/extension-api-explorer: 22.12.1</summary>


### Features

* error document retrieval in API Explorer ([#1161](https://www.github.com/looker-open-source/sdk-codegen/issues/1161)) ([89a94e1](https://www.github.com/looker-open-source/sdk-codegen/commit/89a94e167b8a3e1aa662c0b5de7c585b3eac2f13))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/api-explorer bumped from ^0.9.36 to ^0.9.37
    * @looker/extension-sdk bumped from ^22.10.1 to ^22.12.1
    * @looker/extension-sdk-react bumped from ^22.10.1 to ^22.12.1
    * @looker/extension-utils bumped from ^0.1.13 to ^0.1.14
    * @looker/run-it bumped from ^0.9.36 to ^0.9.37
    * @looker/sdk bumped from ^22.10.1 to ^22.12.1
    * @looker/sdk-codegen bumped from ^21.7.0 to ^21.7.1
</details>
<details><summary>@looker/extension-utils: 0.1.14</summary>


### Features

* copy link button for search ([#1120](https://www.github.com/looker-open-source/sdk-codegen/issues/1120)) ([d6e0c37](https://www.github.com/looker-open-source/sdk-codegen/commit/d6e0c37ae36b1ff4129cf3bb30f8462f4aa49b0d))
* error document retrieval in API Explorer ([#1161](https://www.github.com/looker-open-source/sdk-codegen/issues/1161)) ([89a94e1](https://www.github.com/looker-open-source/sdk-codegen/commit/89a94e167b8a3e1aa662c0b5de7c585b3eac2f13))
* error documentation redirect and support for detailed error content ([#1167](https://www.github.com/looker-open-source/sdk-codegen/issues/1167)) ([5b4fc5b](https://www.github.com/looker-open-source/sdk-codegen/commit/5b4fc5b91e05ed4ccd9090724e4ac3f506b541fd))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from ^22.10.1 to ^22.12.1
    * @looker/extension-sdk-react bumped from ^22.10.1 to ^22.12.1
    * @looker/sdk-rtl bumped from ^21.3.4 to ^21.4.0
    * @looker/code-editor bumped from ^0.1.23 to ^0.1.24
</details>
<details><summary>@looker/hackathon: 22.12.1</summary>


### Features

* error document retrieval in API Explorer ([#1161](https://www.github.com/looker-open-source/sdk-codegen/issues/1161)) ([89a94e1](https://www.github.com/looker-open-source/sdk-codegen/commit/89a94e167b8a3e1aa662c0b5de7c585b3eac2f13))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/code-editor bumped from ^0.1.23 to ^0.1.24
    * @looker/extension-sdk bumped from ^22.10.1 to ^22.12.1
    * @looker/extension-sdk-react bumped from ^22.10.1 to ^22.12.1
    * @looker/extension-utils bumped from ^0.1.13 to ^0.1.14
    * @looker/sdk bumped from ^22.10.1 to ^22.12.1
    * @looker/sdk-rtl bumped from ^21.3.4 to ^21.4.0
    * @looker/wholly-sheet bumped from ^0.5.32 to ^0.5.33
</details>
<details><summary>@looker/run-it: 0.9.37</summary>


### Features

* copy link button for search ([#1120](https://www.github.com/looker-open-source/sdk-codegen/issues/1120)) ([d6e0c37](https://www.github.com/looker-open-source/sdk-codegen/commit/d6e0c37ae36b1ff4129cf3bb30f8462f4aa49b0d))
* error document retrieval in API Explorer ([#1161](https://www.github.com/looker-open-source/sdk-codegen/issues/1161)) ([89a94e1](https://www.github.com/looker-open-source/sdk-codegen/commit/89a94e167b8a3e1aa662c0b5de7c585b3eac2f13))


### Bug Fixes

* whitespace under CollapserCard child components ([#1162](https://www.github.com/looker-open-source/sdk-codegen/issues/1162)) ([89fbf29](https://www.github.com/looker-open-source/sdk-codegen/commit/89fbf2911701b598bf9d673cef00e790a1bc8207))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/code-editor bumped from ^0.1.23 to ^0.1.24
    * @looker/extension-utils bumped from ^0.1.13 to ^0.1.14
    * @looker/sdk bumped from ^22.10.1 to ^22.12.1
    * @looker/sdk-codegen bumped from ^21.7.0 to ^21.7.1
    * @looker/sdk-rtl bumped from ^21.3.4 to ^21.4.0
</details>
<details><summary>@looker/sdk: 22.12.1</summary>


### Features

* generate SDKs for Looker 22.12 ([#1175](https://www.github.com/looker-open-source/sdk-codegen/issues/1175)) ([6f427a7](https://www.github.com/looker-open-source/sdk-codegen/commit/6f427a71dd30669afc901a47418decd59b977a7a))
* generate SDKs for Looker 22.14 ([#1176](https://www.github.com/looker-open-source/sdk-codegen/issues/1176)) ([328d3e5](https://www.github.com/looker-open-source/sdk-codegen/commit/328d3e5710fc80caf5691b8d3ea3d8b8db358ad6))
* regenerate Looker 22.12 SDKs ([#1177](https://www.github.com/looker-open-source/sdk-codegen/issues/1177)) ([b3a9b7b](https://www.github.com/looker-open-source/sdk-codegen/commit/b3a9b7bfff6366abce4802b819d19d00ee00cd60))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk-rtl bumped from ^21.3.4 to ^21.4.0
</details>
<details><summary>@looker/sdk-node: 22.12.1</summary>


### Bug Fixes

* add field details for SDK error ([#1134](https://www.github.com/looker-open-source/sdk-codegen/issues/1134)) ([ef1c96d](https://www.github.com/looker-open-source/sdk-codegen/commit/ef1c96d9bc1ae7c27b6ec4b07c7d33f04930d2a7))
* add field details for SDK error ([#1141](https://www.github.com/looker-open-source/sdk-codegen/issues/1141)) ([9af3092](https://www.github.com/looker-open-source/sdk-codegen/commit/9af30928417e773b6e23a539012bdf9381490a13))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from ^22.10.1 to ^22.12.1
    * @looker/sdk-rtl bumped from ^21.3.4 to ^21.4.0
</details>
<details><summary>@looker/sdk-rtl: 21.4.0</summary>


### Features

* error code document retrieval ([#1136](https://www.github.com/looker-open-source/sdk-codegen/issues/1136)) ([305966b](https://www.github.com/looker-open-source/sdk-codegen/commit/305966b943e8dc6fde08d58cbb36febcbae5733f))
* error document retrieval in API Explorer ([#1161](https://www.github.com/looker-open-source/sdk-codegen/issues/1161)) ([89a94e1](https://www.github.com/looker-open-source/sdk-codegen/commit/89a94e167b8a3e1aa662c0b5de7c585b3eac2f13))


### Bug Fixes

* add ErrorDoc class to the Kotlin SDK ([#1143](https://www.github.com/looker-open-source/sdk-codegen/issues/1143)) ([20fbd31](https://www.github.com/looker-open-source/sdk-codegen/commit/20fbd31939e0ff88b9be3fdcf260176069143925))
* add field details for SDK error ([#1134](https://www.github.com/looker-open-source/sdk-codegen/issues/1134)) ([ef1c96d](https://www.github.com/looker-open-source/sdk-codegen/commit/ef1c96d9bc1ae7c27b6ec4b07c7d33f04930d2a7))
* add field details for SDK error ([#1141](https://www.github.com/looker-open-source/sdk-codegen/issues/1141)) ([9af3092](https://www.github.com/looker-open-source/sdk-codegen/commit/9af30928417e773b6e23a539012bdf9381490a13))
* IErrorDetail fields should not be null ([#1146](https://www.github.com/looker-open-source/sdk-codegen/issues/1146)) ([44274b4](https://www.github.com/looker-open-source/sdk-codegen/commit/44274b4a3974ff4b946a9a0f3209c70cd77b245e))
</details>
<details><summary>looker_sdk: 22.12.1</summary>


### Features

* generate SDKs for Looker 22.12 ([#1175](https://www.github.com/looker-open-source/sdk-codegen/issues/1175)) ([6f427a7](https://www.github.com/looker-open-source/sdk-codegen/commit/6f427a71dd30669afc901a47418decd59b977a7a))
* generate SDKs for Looker 22.14 ([#1176](https://www.github.com/looker-open-source/sdk-codegen/issues/1176)) ([328d3e5](https://www.github.com/looker-open-source/sdk-codegen/commit/328d3e5710fc80caf5691b8d3ea3d8b8db358ad6))
* regenerate Looker 22.12 SDKs ([#1177](https://www.github.com/looker-open-source/sdk-codegen/issues/1177)) ([b3a9b7b](https://www.github.com/looker-open-source/sdk-codegen/commit/b3a9b7bfff6366abce4802b819d19d00ee00cd60))


### Bug Fixes

* add error detail handling for Python SDK ([#1170](https://www.github.com/looker-open-source/sdk-codegen/issues/1170)) ([0db7157](https://www.github.com/looker-open-source/sdk-codegen/commit/0db715768deedbf3290cd29c5aa788d9546e64f0))
</details>
<details><summary>@looker/sdk-codegen: 21.7.1</summary>


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk-rtl bumped from ^21.3.4 to ^21.4.0
</details>
<details><summary>@looker/extension-sdk: 22.12.1</summary>


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from ^22.10.1 to ^22.12.1
    * @looker/sdk-rtl bumped from ^21.3.4 to ^21.4.0
</details>
<details><summary>@looker/extension-sdk-react: 22.12.1</summary>


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from ^22.10.1 to ^22.12.1
    * @looker/sdk bumped from ^22.10.1 to ^22.12.1
    * @looker/sdk-rtl bumped from ^21.3.4 to ^21.4.0
</details>
<details><summary>@looker/sdk-codegen-scripts: 21.4.3</summary>


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from ^22.10.1 to ^22.12.1
    * @looker/sdk-codegen bumped from ^21.7.0 to ^21.7.1
    * @looker/sdk-node bumped from ^22.10.1 to ^22.12.1
    * @looker/sdk-rtl bumped from ^21.3.4 to ^21.4.0
</details>
<details><summary>@looker/wholly-sheet: 0.5.33</summary>


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from ^22.10.1 to ^22.12.1
    * @looker/sdk-rtl bumped from ^21.3.4 to ^21.4.0
  * devDependencies
    * @looker/sdk-node bumped from ^22.10.1 to ^22.12.1
</details>


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants