Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SDK language selection as URL search parameter #1123

Merged
merged 31 commits into from
Aug 9, 2022
Merged

feat: SDK language selection as URL search parameter #1123

merged 31 commits into from
Aug 9, 2022

Commits on Aug 2, 2022

  1. SDK parameter in URL and new queryParams type in navigate

    @patnir41
    patnir41 committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    730271f View commit details
    Browse the repository at this point in the history

  2. Added sdk parameter to object passed into navigate

    @patnir41
    patnir41 committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    b1c0af9 View commit details
    Browse the repository at this point in the history

  3. Fixed/removed case for empty object, to be disucssed

    @patnir41
    patnir41 committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    78ca5f5 View commit details
    Browse the repository at this point in the history

  4. Refactor commit wasn 

    't pushed
    @patnir41
    patnir41 committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    af4a710 View commit details
    Browse the repository at this point in the history

  5. Quick comment refactor

    @patnir41
    patnir41 committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    7897da3 View commit details
    Browse the repository at this point in the history

  6. Refactor to have URL drive state in APIExplorer, test additions

    @patnir41
    patnir41 committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    93d5c93 View commit details
    Browse the repository at this point in the history

  7. Minor refactor

    @patnir41
    patnir41 committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    8a9f8b4 View commit details
    Browse the repository at this point in the history

  8. Comment per Bryn request

    @patnir41
    patnir41 committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    92ab597 View commit details
    Browse the repository at this point in the history

  9. Refactor, enforce flow to URL and URL driving state, removed store re… 

    …lated SDK test
    @patnir41
    patnir41 committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    00633a8 View commit details
    Browse the repository at this point in the history

  10. Refactor to pass tests

    @patnir41
    patnir41 committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    7273536 View commit details
    Browse the repository at this point in the history

  11. Fix to All option parameter showing

    @patnir41
    patnir41 committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    9c29e96 View commit details
    Browse the repository at this point in the history

  12. Fix and unit test for choosing SDK = All

    @patnir41
    patnir41 committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    16e3883 View commit details
    Browse the repository at this point in the history

  13. Pushing extension abbreviation to URL, fix state issues, added tests/… 

    …util
    @patnir41
    patnir41 committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    842926c View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. URL drives state over initActions, show sdk=all in URL due to state i… 

    …ssues
    @patnir41
    patnir41 committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    d7436d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. Set initial URL and Explorer state based on initialized state in loca… 

    …l storage settings, sdk=all in URL
    @patnir41
    patnir41 committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    abc3555 View commit details
    Browse the repository at this point in the history

  2. Add back removed line

    @patnir41
    patnir41 committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    8e96e15 View commit details
    Browse the repository at this point in the history

  3. TypeScript error fix

    @patnir41
    patnir41 committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    6a25ce8 View commit details
    Browse the repository at this point in the history

  4. Removes sdk parameter on selecting All

    @patnir41
    patnir41 committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    3170b7a View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. Significant optimizations and change to sdkLanguage storage

    @patnir41
    patnir41 committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    a7f0748 View commit details
    Browse the repository at this point in the history

  2. Working e2e tests

    @patnir41
    patnir41 committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    d399430 View commit details
    Browse the repository at this point in the history

  3. WIP comments from Joseph on e2e and sdkAlias selector

    @patnir41
    patnir41 committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    1898cc2 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2022

  1. Passing e2e tests

    @patnir41
    patnir41 committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    d643f68 View commit details
    Browse the repository at this point in the history

  2. Remove need for catching legacy store value

    @patnir41
    patnir41 committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    391a90b View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. Refactoring & cleanup

    @patnir41
    patnir41 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    141ee1b View commit details
    Browse the repository at this point in the history

  2. Selector refactor, remove redundant logic

    @patnir41
    patnir41 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    047412b View commit details
    Browse the repository at this point in the history

  3. Documentation for allSdkLanguages

    @patnir41
    patnir41 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    7f9f872 View commit details
    Browse the repository at this point in the history

  4. Revert test checking default language selected

    @patnir41
    patnir41 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    bf28b9b View commit details
    Browse the repository at this point in the history

  5. Remove unpredictability with e2e tests

    @patnir41
    patnir41 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    3727b65 View commit details
    Browse the repository at this point in the history

  6. Refactoring and modifying e2e tests

    @patnir41
    patnir41 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    24ded0a View commit details
    Browse the repository at this point in the history

  7. allAlias instead of hardcode 'all'

    @patnir41
    patnir41 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    d8c3f51 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. Merge branch 'main' into patnir41/sdk-sharing-url

    @patnir41
    patnir41 authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    88c99a1 View commit details
    Browse the repository at this point in the history