chore: noStreams skips tally headers in generated source #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `-n` option is used for the code generator, the tally comments at the top of each generated source file are also removed. Consider it "no comment" as well as "no streams"
jkaster
requested review from
whscullin,
bryans99,
joeldodge79,
josephaxisa and
noahamac
whscullin
previously approved these changes
Jul 1, 2021
| // this.p(strs) | ||
| // } | ||
| // return this | ||
| // } |
There was a problem hiding this comment.
Yeah. I'll remove it in an update
josephaxisa
approved these changes
Jul 1, 2021
This comment has been minimized.
This comment has been minimized.
|
is there a follow on generated code change? also, fwiw this change will not show up in any changelog nor, in and of itself, cause release-please to recognize any need for a version bump ( |
|
There is no code change for the external SDK. Let me know how to fix it so it gets released, please. |
actually looks like if you do want a changelog entry then we can add a temporary release-please config entry (under let me know if you want that (or feel free to put up a PR for release-please-config.json) |
|
It's really for internal use, so the changelog doesn't matter. Thanks. |
joeldodge79
added a commit
that referenced
this pull request
Jul 1, 2021
temp override changelog types for sdk-codegen-scripts for #727 set next versions on non-standard packages
joeldodge79
added a commit
that referenced
this pull request
Jul 1, 2021
temp override changelog types for sdk-codegen-scripts for #727 set next versions on non-standard packages
jkaster
pushed a commit
that referenced
this pull request
Jul 1, 2021
🤖 I have created a release \*beep\* \*boop\* --- <details><summary>sdk-codegen-all: 1.9.1</summary> ### Bug Fixes * paging parsing issues ([#728](https://www.github.com/looker-open-source/sdk-codegen/issues/728)) ([f8eec43](https://www.github.com/looker-open-source/sdk-codegen/commit/f8eec43bdfbe337d41b1da02c127d690c8815ed3)) </details> <details><summary>@looker/sdk-codegen-scripts: 21.0.20</summary> ### Bug Fixes * noStreams skips tally headers in generated source ([#727](https://www.github.com/looker-open-source/sdk-codegen/issues/727)) ([113c2c5](https://www.github.com/looker-open-source/sdk-codegen/commit/113c2c50c07c621cf94841af75557704fc3f5df7)) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from ^21.8.1 to ^21.8.2 * @looker/sdk-codegen bumped from ^21.0.18 to ^21.0.19 * @looker/sdk-node bumped from ^21.8.0 to ^21.8.1 * @looker/sdk-rtl bumped from ^21.0.14 to ^21.0.15 </details> <details><summary>@looker/sdk-rtl: 21.0.15</summary> ### Bug Fixes * paging parsing issues ([#728](https://www.github.com/looker-open-source/sdk-codegen/issues/728)) ([f8eec43](https://www.github.com/looker-open-source/sdk-codegen/commit/f8eec43bdfbe337d41b1da02c127d690c8815ed3)) </details> <details><summary>@looker/sdk: 21.8.2</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk-rtl bumped from ^21.0.14 to ^21.0.15 </details> <details><summary>@looker/sdk-codegen: 21.0.19</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk-rtl bumped from ^21.0.14 to ^21.0.15 </details> <details><summary>@looker/extension-sdk: 21.8.2</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from ^21.8.1 to ^21.8.2 * @looker/sdk-rtl bumped from ^21.0.14 to ^21.0.15 </details> <details><summary>@looker/sdk-node: 21.8.1</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from ^21.8.1 to ^21.8.2 * @looker/sdk-rtl bumped from ^21.0.14 to ^21.0.15 </details> <details><summary>@looker/code-editor: 0.1.4</summary> ### Dependencies * The following workspace dependencies were updated * devDependencies * @looker/sdk-codegen bumped from ^21.0.18 to ^21.0.19 </details> <details><summary>@looker/extension-sdk-react: 21.8.2</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from ^21.8.1 to ^21.8.2 * @looker/sdk bumped from ^21.8.1 to ^21.8.2 * @looker/sdk-rtl bumped from ^21.0.14 to ^21.0.15 </details> <details><summary>@looker/wholly-sheet: 0.5.10</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from ^21.8.1 to ^21.8.2 * @looker/sdk-rtl bumped from ^21.0.14 to ^21.0.15 * devDependencies * @looker/sdk-node bumped from ^21.8.0 to ^21.8.1 </details> <details><summary>@looker/run-it: 0.9.11</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from ^21.8.1 to ^21.8.2 * @looker/sdk-codegen bumped from ^21.0.18 to ^21.0.19 * @looker/code-editor bumped from ^0.1.3 to ^0.1.4 * @looker/sdk-rtl bumped from ^21.0.14 to ^21.0.15 </details> <details><summary>@looker/hackathon: 21.8.1</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from ^21.8.1 to ^21.8.2 * @looker/extension-sdk-react bumped from ^21.8.1 to ^21.8.2 * @looker/sdk bumped from ^21.8.1 to ^21.8.2 * @looker/sdk-rtl bumped from ^21.0.14 to ^21.0.15 * @looker/wholly-sheet bumped from ^0.5.9 to ^0.5.10 </details> <details><summary>@looker/api-explorer: 0.9.11</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from ^0.1.3 to ^0.1.4 * @looker/run-it bumped from ^0.9.10 to ^0.9.11 * @looker/sdk bumped from ^21.8.1 to ^21.8.2 * @looker/sdk-codegen bumped from ^21.0.18 to ^21.0.19 * @looker/sdk-rtl bumped from ^21.0.14 to ^21.0.15 * devDependencies * @looker/sdk-codegen-scripts bumped from ^21.0.19 to ^21.0.20 * @looker/sdk-node bumped from ^21.8.0 to ^21.8.1 </details> <details><summary>@looker/extension-api-explorer: 21.8.1</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/api-explorer bumped from ^0.9.10 to ^0.9.11 * @looker/extension-sdk bumped from ^21.8.1 to ^21.8.2 * @looker/extension-sdk-react bumped from ^21.8.1 to ^21.8.2 * @looker/run-it bumped from ^0.9.10 to ^0.9.11 * @looker/sdk bumped from ^21.8.1 to ^21.8.2 * @looker/sdk-codegen bumped from ^21.0.18 to ^21.0.19 </details> This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
-noption is used for the code generator, the tally comments at the top of each generated source file are also removed.Consider it "no comment" as well as "no streams"