-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release-please config #730
Conversation
temp override changelog types for sdk-codegen-scripts for #727 set next versions on non-standard packages
"packages/sdk-codegen": { "release-as": "21.0.18" }, | ||
"packages/sdk-codegen-scripts": { "release-as": "21.0.18" }, | ||
"packages/sdk-codegen": { "release-as": "21.0.19" }, | ||
"packages/sdk-codegen-scripts": { "release-as": "21.0.20", "changelog-sections": [{"type": "chore", "section": "Bug Fixes"}] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkaster I just saw your reply - would you like me to undo this (no changelog entry) or leave it (changelog entry)?
"packages/sdk-codegen-scripts": { "release-as": "21.0.20", "changelog-sections": [{"type": "chore", "section": "Bug Fixes"}] }, | |
"packages/sdk-codegen-scripts": { "release-as": "21.0.20" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep things as you had them and not accommodate my mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine for now but we should retain the behavior you had before and I'll use more accurate PR tags in the future.
"packages/sdk-codegen": { "release-as": "21.0.18" }, | ||
"packages/sdk-codegen-scripts": { "release-as": "21.0.18" }, | ||
"packages/sdk-codegen": { "release-as": "21.0.19" }, | ||
"packages/sdk-codegen-scripts": { "release-as": "21.0.20", "changelog-sections": [{"type": "chore", "section": "Bug Fixes"}] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep things as you had them and not accommodate my mistake
No description provided.