Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Looker 21.18 bindings #865

Merged
merged 3 commits into from
Oct 20, 2021
Merged

feat: Looker 21.18 bindings #865

merged 3 commits into from
Oct 20, 2021

Conversation

drstrangelooker
Copy link
Collaborator

No description provided.

@google-cla google-cla bot added the cla: yes label Oct 19, 2021
@drstrangelooker
Copy link
Collaborator Author

FYI I used 21.12, 21.16, and 21.18 as the supported versions since 21.12 is ESR, but we typically only support three.

@github-actions
Copy link
Contributor

Typescript Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 281b40f.

@github-actions
Copy link
Contributor

Python Tests

    9 files      9 suites   2m 13s ⏱️
140 tests 140 ✔️ 0 💤 0 ❌
765 runs  765 ✔️ 0 💤 0 ❌

Results for commit 279884a.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files    75 suites   3m 45s ⏱️
167 tests 163 ✔️   4 💤 0 ❌
555 runs  543 ✔️ 12 💤 0 ❌

Results for commit 279884a.

jkaster
jkaster reviewed Oct 19, 2021
View reviewed changes
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the questions about release versions, this looks good to me

.release-please-manifest.json Outdated Show resolved Hide resolved
csharp/sdk/3.1/models.cs Show resolved Hide resolved
@jkaster jkaster self-requested a review October 20, 2021 00:04
jkaster
jkaster approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Python Tests

    9 files      9 suites   2m 8s ⏱️
140 tests 140 ✔️ 0 💤 0 ❌
765 runs  765 ✔️ 0 💤 0 ❌

Results for commit 74396f4.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files    75 suites   3m 54s ⏱️
167 tests 163 ✔️   4 💤 0 ❌
555 runs  543 ✔️ 12 💤 0 ❌

Results for commit 74396f4.

@drstrangelooker drstrangelooker merged commit fa98888 into main Oct 20, 2021
@drstrangelooker drstrangelooker deleted the release-21.18 branch October 20, 2021 00:23
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaster jkaster jkaster approved these changes

@joeldodge79 joeldodge79 Awaiting requested review from joeldodge79

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drstrangelooker @jkaster