Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SDK build for 22.0. #959

Merged
merged 13 commits into from
Feb 3, 2022
Merged

feat: SDK build for 22.0. #959

merged 13 commits into from
Feb 3, 2022

Conversation

drstrangelooker
Copy link
Collaborator

No description provided.

@joeldodge79 joeldodge79 self-requested a review January 27, 2022 20:28
@github-actions

This comment has been minimized.

@drstrangelooker drstrangelooker changed the title SDK build for 22.0 chore: SDK build for 22.0 Jan 27, 2022
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

APIX Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 20fca545.

@github-actions

This comment has been minimized.

Copy link
Contributor

@joeldodge79 joeldodge79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel pretty strongly that we should cleanup the current state of the past couple releases and release #930 as a patch before we merge 22.0 in

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

APIX Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 3a755020.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@drstrangelooker drstrangelooker force-pushed the drstrangelove/22.0 branch 2 times, most recently from fd6355b to 563f89c Compare January 28, 2022 19:06
@github-actions

This comment has been minimized.

@drstrangelooker drstrangelooker force-pushed the drstrangelove/22.0 branch 4 times, most recently from 8bf3b6c to c35042a Compare January 28, 2022 19:38
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@drstrangelooker drstrangelooker force-pushed the drstrangelove/22.0 branch 2 times, most recently from e1fdabe to a43da3c Compare January 28, 2022 20:56
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Typescript Tests

    6 files    75 suites   3m 16s ⏱️
169 tests 165 ✔️   4 💤 0 ❌
561 runs  549 ✔️ 12 💤 0 ❌

Results for commit 98e9bcf.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

Codegen Tests

    1 files    17 suites   30s ⏱️
397 tests 383 ✔️ 14 💤 0 ❌
398 runs  384 ✔️ 14 💤 0 ❌

Results for commit fe94373.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

Python Tests

    9 files      9 suites   1m 55s ⏱️
140 tests 140 ✔️ 0 💤 0 ❌
765 runs  765 ✔️ 0 💤 0 ❌

Results for commit fe94373.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

Typescript Tests

    6 files    75 suites   3m 14s ⏱️
169 tests 165 ✔️   4 💤 0 ❌
561 runs  549 ✔️ 12 💤 0 ❌

Results for commit fe94373.

@drstrangelooker drstrangelooker changed the title chore: SDK build for 22.0 chore: SDK build for 22.0. Feb 2, 2022
Copy link
Contributor

@joeldodge79 joeldodge79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the python generated code changes and it seems good to me. I briefly looked at the workflow file changes and they seem reasonable too though I haven't fully grokked all the changes.

One change we need can be accomplished in two ways.

  1. separate out the "update CI for 22.0" changes (workflows etc) from the codegen for 22.0 (generated language files) into a separate PR and merge them first - that seems to be the intention with the title of this PR: chore: SDK build for 22.0
  2. leave it all combined as is BUT update the title to feat: Looker 22.0 release (otherwise release-please will NOT pickup the fact that there are user facing changes in this PR because chore is not considered user facing)

Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with Joel's feedback. Nothing further to add right now.

.github/workflows/required-checks-hack-ci.yml Show resolved Hide resolved
@drstrangelooker drstrangelooker changed the title chore: SDK build for 22.0. feat: SDK build for 22.0. Feb 3, 2022
@drstrangelooker
Copy link
Collaborator Author

@joeldodge79 I renamed it to feat:.

@joeldodge79 joeldodge79 self-requested a review February 3, 2022 22:12
Copy link
Contributor

@joeldodge79 joeldodge79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on moving the CI noise-reduction effort forward!!

I'll approve this but with a note: we don't have a good mechanism for testing previous sdk versions against newer Looker versions. And maybe that's not a big deal - if something breaks then upgrade to latest SDK which DO test against all previously supported Looker versions. However, in the old workflow where we modified CI separately and beforehand to test against the next Looker release, we had at least a transient rolling window of "SDK for Looker version N works against Looker version N+1". If the generated code changes for 22.0 are merged together with the CI changes to test against 22.0 then we lose that for SDK(21.20) vs Looker(22.0). But I don't think it's critical, just pointing it out. That and my manta of keeping a PR as single purpose as possible (update CI vs generate new sdk)

@drstrangelooker drstrangelooker merged commit de651b3 into main Feb 3, 2022
@drstrangelooker drstrangelooker deleted the drstrangelove/22.0 branch February 3, 2022 22:28
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@drstrangelooker
Copy link
Collaborator Author

OK. I'll do that next time.

@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants