Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitrix24 Notification #3610

Closed
1 task done
furkanipek opened this issue Aug 19, 2023 · 5 comments · Fixed by #3620
Closed
1 task done

Bitrix24 Notification #3610

furkanipek opened this issue Aug 19, 2023 · 5 comments · Fixed by #3620
Labels
feature-request Request for new features to be added

Comments

@furkanipek
Copy link
Contributor

furkanipek commented Aug 19, 2023

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

New Notification

Fixes #3620

🔖 Feature description

I would like it to be added so that we receive notifications through the Bitrix24 system.

✔️ Solution

A system that sends notifications can be added using the Bitrix24 webhook.

❓ Alternatives

No response

📝 Additional Context

No response

@furkanipek furkanipek added the feature-request Request for new features to be added label Aug 19, 2023
@CommanderStorm
Copy link
Collaborator

This is kind of niche/uncommon notification provider.
If you/someone else would like to contribute such a provider, here is the Contribution guide:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md

If you do decide to do this, please not these two suggestions, which often push PRs back by a review-cycle:

  • Ensure that the PR includes screenshots of the DOWN/UP and testing/cert-expiry events.
  • All keys that can/should be translated are in en.json (⇒ our translators can translate this and no merge-confilicts between Weblate and master can arise)

@rezzorix
Copy link
Contributor

Bitrix supports webhooks; wouldn’t that already be sufficient?

@furkanipek
Copy link
Contributor Author

This is kind of niche/uncommon notification provider. If you/someone else would like to contribute such a provider, here is the Contribution guide: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md

If you do decide to do this, please not these two suggestions, which often push PRs back by a review-cycle:

  • Ensure that the PR includes screenshots of the DOWN/UP and testing/cert-expiry events.
  • All keys that can/should be translated are in en.json (⇒ our translators can translate this and no merge-confilicts between Weblate and master can arise)

I will contribute as soon as possible, thank you for your response.

@furkanipek
Copy link
Contributor Author

Bitrix supports webhooks; wouldn’t that already be sufficient?

Bitrix24 webhook is not working very well at Uptime, I did some tests, I will try again, thank you for your reply.

@furkanipek
Copy link
Contributor Author

Hello,

I have made the necessary additions. Have a nice day.

#3620

@furkanipek furkanipek reopened this Aug 22, 2023
furkanipek added a commit to furkanipek/uptime-kuma that referenced this issue Nov 15, 2023
CommanderStorm added a commit to furkanipek/uptime-kuma that referenced this issue May 19, 2024
CommanderStorm added a commit to furkanipek/uptime-kuma that referenced this issue May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features to be added
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants