Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitrix24 Webhook notification #3620

Merged
merged 13 commits into from
May 19, 2024

Conversation

furkanipek
Copy link
Contributor

@furkanipek furkanipek commented Aug 21, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Added notification provider using Bitrix24 Webhook.
Resolves #3610

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Uptime Kuma - Bitrix24 Settings

Bitrix24 - Notifications

@furkanipek furkanipek mentioned this pull request Aug 21, 2023
1 task
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have testing and certificate-expiry notifications as noted in the issue.
Could you provide a screenshot of this case?
You can find expired certs at https://badssl.com/

server/notification-providers/bitrix24.js Outdated Show resolved Hide resolved
server/notification-providers/bitrix24.js Outdated Show resolved Hide resolved
server/notification-providers/bitrix24.js Outdated Show resolved Hide resolved
src/components/notifications/Bitrix24.vue Outdated Show resolved Hide resolved
furkanipek and others added 4 commits August 21, 2023 13:58
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
@furkanipek
Copy link
Contributor Author

furkanipek commented Aug 21, 2023

DOWN/UP and testing/cert-expiry

@CommanderStorm Since I took the Telegram Notification files in Uptime Kuma as a reference, I added Bitrix24 without changing the structure.

I am sending screenshots.

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the following to the description? (this way this issue is not left open once the PR is merged)
Resolves #3610

@furkanipek
Copy link
Contributor Author

Could you add the following to the description? (this way this issue is not left open once the PR is merged) Resolves #3610

  • Ensure that the PR includes screenshots of the DOWN/UP and testing/cert-expiry events.
  • All keys that can/should be translated are in en.json (⇒ our translators can translate this and no merge-confilicts between Weblate and master can arise)

Copy link
Contributor

@Computroniks Computroniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the eslint rules in the 2.x branch require that all methods have JSDoc comments. Given that this is a notification provider and as such inherits from the base class, @inheritdoc is sufficient here.

server/notification-providers/bitrix24.js Show resolved Hide resolved
@CommanderStorm
Copy link
Collaborator

Re: #3620 (comment)
No, I literally meant please add the string "Resolves #3610" to the description of this Pull Request.
You can read more about linking a pull request to an issue here

@furkanipek
Copy link
Contributor Author

Could you add the following to the description? (this way this issue is not left open once the PR is merged) Resolves #3610

  • Ensure that the PR includes screenshots of the DOWN/UP and testing/cert-expiry events.
  • All keys that can/should be translated are in en.json (⇒ our translators can translate this and no merge-confilicts between Weblate and master can arise)

The image I uploaded was wrong, I wrote to inform you.

Co-authored-by: Matthew Nickson <mnickson@sidingsmedia.com>
@louislam louislam added this to the 2.0.0 milestone Aug 23, 2023
@louislam louislam added the question Further information is requested label Sep 9, 2023
@louislam louislam modified the milestones: 2.0.0, 2.1.0 Oct 16, 2023
@chakflying chakflying added the area:notifications Everything related to notifications label Dec 2, 2023
@CommanderStorm CommanderStorm removed the question Further information is requested label Jan 18, 2024
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new notification provider 🎉

All changes in this PR are small and uncontroversial
⇒ merging with junior maintainer approval

server/notification-providers/bitrix24.js Outdated Show resolved Hide resolved
@CommanderStorm CommanderStorm modified the milestones: 2.1.0, 2.0.0 May 19, 2024
@CommanderStorm CommanderStorm merged commit 55b2d4b into louislam:master May 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitrix24 Notification
5 participants