-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bitrix24 Webhook notification #3620
Add Bitrix24 Webhook notification #3620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have testing and certificate-expiry notifications as noted in the issue.
Could you provide a screenshot of this case?
You can find expired certs at https://badssl.com/
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
@CommanderStorm Since I took the Telegram Notification files in Uptime Kuma as a reference, I added Bitrix24 without changing the structure. I am sending screenshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the following to the description? (this way this issue is not left open once the PR is merged)
Resolves #3610
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to the eslint rules in the 2.x branch require that all methods have JSDoc comments. Given that this is a notification provider and as such inherits from the base class, @inheritdoc
is sufficient here.
Re: #3620 (comment) |
The image I uploaded was wrong, I wrote to inform you. |
Co-authored-by: Matthew Nickson <mnickson@sidingsmedia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new notification provider 🎉
All changes in this PR are small and uncontroversial
⇒ merging with junior maintainer approval
…tus instead of the `msg`
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Added notification provider using Bitrix24 Webhook.
Resolves #3610
Type of change
Checklist
(including JSDoc for methods)
Screenshots (if any)