[Ntfy] Only include action link if monitor url is defined #3274

[philbot9]

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

• I have read and understand the pull request rules.

Description

Fixes #3274

In ntfy v2.8 attempting to send a notification with an action that's missing a URL results in failure.

This bugfix was tested and is working with ntfy v2.8.

Type of change

Please delete any options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Checklist

• My code follows the style guidelines of this project
• I ran ESLint and other linters for modified files
• I have performed a self-review of my own code and tested it
• I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
• My changes generates no new warnings
• My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

[chakflying]

The value of url is https:// by default. (see #3327)

This should also be checked to prevent the empty url from being sent.

[philbot9]

Ok, the PR has been updated.

[CommanderStorm]

Thanks for the bugfix.

All changes in this PR are small and uncontroversial.
⇒ merging with junior maintainer approval as by contribution guide

[Zaid-maker]

why the actions are failing? on npm i npm@9 -g step?

[CommanderStorm]

Really unsure why.
I don't think this is related to any commit we did, as that has been failing since #4479 and said PR does not touch npm.
Ideas?

[Zaid-maker]

Really unsure why. I don't think this is related to any commit we did, as that has been failing since #4479 and said PR does not touch npm. Ideas?

I looked up on Stack overflow and find we had to pass --force flag to overwrite the node_modules in cache, and this is most likely because of node_modules cache as far said in the fix.

https://stackoverflow.com/questions/39293636/npm-err-error-eperm-operation-not-permitted-rename