[Ntfy] Action link should only be included if url is defined

[cfouche3005]

⚠️ Please verify that this bug has NOT been raised before.

• I checked and didn't find similar issue

🛡️ Security Policy

• I agree to have read this project Security Policy

Description

When using the ntfy notification, uptime-kuma create an action button to go to the uptime-kuma page on the ntfy notification but the actual link is not completed. The main URL is setup on uptime-kuma

👟 Reproduction steps

Create an ntfy notification
Receive a down or up notification
Click on the action button on ntfy
See the result

👀 Expected behavior

the action button take you to the uptime-kuma page

😓 Actual Behavior

the action button take you to a about:blank page

🐻 Uptime-Kuma Version

1.22.0-beta.0

💻 Operating System and Arch

Fly.io

🌐 Browser

Not browser related

🐋 Docker Version

Fly.io

🟩 NodeJS Version

No response

📝 Relevant log output

No response

[CommanderStorm]

Relavant Code:
https://github.com/louislam/uptime-kuma/blob/master/server/notification-providers/ntfy.js#L58

[clesmian]

This seems to happen for those cases where no URL is available, e.g. when monitoring a docker container. Could this also be the issue in your case @cfouche3005 ?

[cfouche3005]

Yes, I can confirm (when I create an http monitor, the button on the notification redirect me to the monitored website), I was thinking that the button redirected to the probe on uptime-kuma, not the monitored website (but it make sense)

[CommanderStorm]

This seems to happen for those cases where no URL is available

@cfouche3005
What is the expected case and what is currently implemented?
Is this resolved?
I am confused

[cfouche3005]

@CommanderStorm Sorry if it wasn't clear (English is not my first language), the issue is just a "normal" behavior : Uptime-Kuma set the action button web link with the monitored website but for Groups (or docker container), witch doesn't have a web link, it just set a blank link. The rest of the issue was just a misunderstanding of the actual behavior.
This issue might be a non issue.

[clesmian]

Just to clarify, the issue occurs currently for those monitors that do not have a URL associated to them (like docker containers).

The ntfy notification logic just assumes, that the URL field is set for every monitor and sets it as the target action of the "Open " button, it adds to the notification.

This leads to confusion to the user, because the button leads to an empty tab. Therefore uptime-kuma should either set the action to something meaningful (like a link to uptime-kuma itself) or don't display the button at all.

EDITED to state my opinion more clearly